Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-12-01 Thread Konrad Rzeszutek Wilk
On Thu, Nov 27, 2014 at 05:46:28PM +, Stefano Stabellini wrote: > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > On Nov 27, 2014 10:26 AM, Stefano Stabellini > > wrote: > > > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > > On Nov 27, 2014 9:58 AM, Stefano Stabellini >

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Nov 27, 2014 10:26 AM, Stefano Stabellini > wrote: > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > On Nov 27, 2014 9:58 AM, Stefano Stabellini > > > wrote: > > > > > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote:

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Konrad Rzeszutek Wilk
On Nov 27, 2014 10:26 AM, Stefano Stabellini wrote: > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > On Nov 27, 2014 9:58 AM, Stefano Stabellini > > wrote: > > > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > > On Nov 27, 2014 7:46 AM, Stefano Stabellini > > > > w

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Nov 27, 2014 9:58 AM, Stefano Stabellini > wrote: > > > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > > On Nov 27, 2014 7:46 AM, Stefano Stabellini > > > wrote: > > > > > > > > Konrad, I think we should have this fix in 4.5: wi

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Konrad Rzeszutek Wilk
On Nov 27, 2014 9:58 AM, Stefano Stabellini wrote: > > On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > > On Nov 27, 2014 7:46 AM, Stefano Stabellini > > wrote: > > > > > > Konrad, I think we should have this fix in 4.5: without it > > > vif=[ 'model=virtio-net' ] crashes QEMU. > > >

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
On Thu, 27 Nov 2014, Konrad Rzeszutek Wilk wrote: > On Nov 27, 2014 7:46 AM, Stefano Stabellini > wrote: > > > > Konrad, I think we should have this fix in 4.5: without it > > vif=[ 'model=virtio-net' ] crashes QEMU. > > > > Is it an regression? Good question: I was trying to investigate that

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Konrad Rzeszutek Wilk
On Nov 27, 2014 7:46 AM, Stefano Stabellini wrote: > > Konrad, I think we should have this fix in 4.5: without it > vif=[ 'model=virtio-net' ] crashes QEMU. > Is it an regression? > > On Thu, 27 Nov 2014, Peter Maydell wrote: > > On 27 November 2014 at 12:33, Michael S. Tsirkin wrote: > >

Re: [Qemu-devel] [2.2 PATCH V2 for-4.5] virtio-net: fix unmap leak

2014-11-27 Thread Stefano Stabellini
Konrad, I think we should have this fix in 4.5: without it vif=[ 'model=virtio-net' ] crashes QEMU. On Thu, 27 Nov 2014, Peter Maydell wrote: > On 27 November 2014 at 12:33, Michael S. Tsirkin wrote: > > On Thu, Nov 27, 2014 at 06:04:03PM +0800, Jason Wang wrote: > >> virtio_net_handle_ctrl() an