Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-04 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Jul 21, 2022 at 06:36:21PM +0200, Paolo Bonzini wrote: >> From: "Jason A. Donenfeld" >> >> Tiny machines optimized for fast boot time generally don't use EFI, >> which means a random seed has to be supplied some other way. For this >> purpose, Linux (≥5.

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-04 Thread Jason A. Donenfeld
Hi Daniel, On Thu, Aug 4, 2022 at 2:01 PM Daniel P. Berrangé wrote: > > On Thu, Jul 21, 2022 at 06:36:21PM +0200, Paolo Bonzini wrote: > > From: "Jason A. Donenfeld" > > > > Tiny machines optimized for fast boot time generally don't use EFI, > > which means a random seed has to be supplied some

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-04 Thread Daniel P . Berrangé
On Thu, Aug 04, 2022 at 02:13:41PM +0200, Jason A. Donenfeld wrote: > Hi Daniel, > > On Thu, Aug 4, 2022 at 2:01 PM Daniel P. Berrangé wrote: > > > > On Thu, Jul 21, 2022 at 06:36:21PM +0200, Paolo Bonzini wrote: > > > From: "Jason A. Donenfeld" > > > > > > Tiny machines optimized for fast boot

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-04 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 06:36:21PM +0200, Paolo Bonzini wrote: > From: "Jason A. Donenfeld" > > Tiny machines optimized for fast boot time generally don't use EFI, > which means a random seed has to be supplied some other way. For this > purpose, Linux (≥5.20) supports passing a seed in the set

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Laszlo Ersek
On 08/04/22 00:23, Michael S. Tsirkin wrote: > On Thu, Aug 04, 2022 at 12:08:07AM +0200, Jason A. Donenfeld wrote: >> Hi Michael, >> >> On Wed, Aug 03, 2022 at 06:03:20PM -0400, Michael S. Tsirkin wrote: >>> On Wed, Aug 03, 2022 at 07:07:52PM +0200, Jason A. Donenfeld wrote: On Wed, Aug 03, 20

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Michael S. Tsirkin
On Thu, Aug 04, 2022 at 12:08:07AM +0200, Jason A. Donenfeld wrote: > Hi Michael, > > On Wed, Aug 03, 2022 at 06:03:20PM -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 03, 2022 at 07:07:52PM +0200, Jason A. Donenfeld wrote: > > > On Wed, Aug 03, 2022 at 03:34:04PM +0200, Jason A. Donenfeld wrote

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Jason A. Donenfeld
Hi Michael, On Wed, Aug 03, 2022 at 06:03:20PM -0400, Michael S. Tsirkin wrote: > On Wed, Aug 03, 2022 at 07:07:52PM +0200, Jason A. Donenfeld wrote: > > On Wed, Aug 03, 2022 at 03:34:04PM +0200, Jason A. Donenfeld wrote: > > > On Wed, Aug 03, 2022 at 03:11:48PM +0200, Jason A. Donenfeld wrote: >

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2022 at 07:07:52PM +0200, Jason A. Donenfeld wrote: > On Wed, Aug 03, 2022 at 03:34:04PM +0200, Jason A. Donenfeld wrote: > > On Wed, Aug 03, 2022 at 03:11:48PM +0200, Jason A. Donenfeld wrote: > > > Thanks for the info. Very helpful. Looking into it now. > > > > So interestingly,

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Jason A. Donenfeld
On Wed, Aug 03, 2022 at 03:34:04PM +0200, Jason A. Donenfeld wrote: > On Wed, Aug 03, 2022 at 03:11:48PM +0200, Jason A. Donenfeld wrote: > > Thanks for the info. Very helpful. Looking into it now. > > So interestingly, this is not a new issue. If you pass any type of setup > data, OVMF appears to

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Jason A. Donenfeld
On Wed, Aug 03, 2022 at 03:11:48PM +0200, Jason A. Donenfeld wrote: > Thanks for the info. Very helpful. Looking into it now. So interestingly, this is not a new issue. If you pass any type of setup data, OVMF appears to be doing something unusual and passing 0x for all the entries, rather

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Jason A. Donenfeld
Hi Daniel, On Wed, Aug 03, 2022 at 11:52:25AM +0100, Daniel P. Berrangé wrote: > On Tue, Aug 02, 2022 at 05:13:26PM +0200, Jason A. Donenfeld wrote: > > Hi Xiaoyao, > > > > On Tue, Aug 2, 2022 at 5:06 PM Jason A. Donenfeld wrote: > > > > > > Hi Xiaoyao, > > > > > > On Tue, Aug 02, 2022 at 10:53:

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Daniel P . Berrangé
On Tue, Aug 02, 2022 at 05:13:26PM +0200, Jason A. Donenfeld wrote: > Hi Xiaoyao, > > On Tue, Aug 2, 2022 at 5:06 PM Jason A. Donenfeld wrote: > > > > Hi Xiaoyao, > > > > On Tue, Aug 02, 2022 at 10:53:07PM +0800, Xiaoyao Li wrote: > > > yes, with >= 7.1, pcmc->legacy_no_rng_seed = false by defaul

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-02 Thread Xiaoyao Li
On 8/2/2022 11:13 PM, Jason A. Donenfeld wrote: Hi Xiaoyao, On Tue, Aug 2, 2022 at 5:06 PM Jason A. Donenfeld wrote: Hi Xiaoyao, On Tue, Aug 02, 2022 at 10:53:07PM +0800, Xiaoyao Li wrote: yes, with >= 7.1, pcmc->legacy_no_rng_seed = false by default, and RNG seed is used. This is intende

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-02 Thread Jason A. Donenfeld
Hi Xiaoyao, On Tue, Aug 2, 2022 at 5:06 PM Jason A. Donenfeld wrote: > > Hi Xiaoyao, > > On Tue, Aug 02, 2022 at 10:53:07PM +0800, Xiaoyao Li wrote: > > yes, with >= 7.1, pcmc->legacy_no_rng_seed = false by default, and RNG > > seed is used. > > This is intended behavior. Being on by default is b

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-02 Thread Jason A. Donenfeld
Hi Xiaoyao, On Tue, Aug 02, 2022 at 10:53:07PM +0800, Xiaoyao Li wrote: > yes, with >= 7.1, pcmc->legacy_no_rng_seed = false by default, and RNG > seed is used. This is intended behavior. Being on by default is basically the whole point of it. Otherwise it's useless. > > > Either way, this sho

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-02 Thread Xiaoyao Li
On 8/2/2022 9:21 PM, Jason A. Donenfeld wrote: Hi, On Tue, Aug 02, 2022 at 11:28:15AM +0800, Xiaoyao Li wrote: static void pc_q35_7_0_machine_options(MachineClass *m) { +PCMachineClass *pcmc = PC_MACHINE_CLASS(m); pc_q35_7_1_machine_options(m); m->alias = NULL; +pcmc

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-02 Thread Jason A. Donenfeld
Hi, On Tue, Aug 02, 2022 at 11:28:15AM +0800, Xiaoyao Li wrote: > > static void pc_q35_7_0_machine_options(MachineClass *m) > > { > > +PCMachineClass *pcmc = PC_MACHINE_CLASS(m); > > pc_q35_7_1_machine_options(m); > > m->alias = NULL; > > +pcmc->legacy_no_rng_seed = true; >

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-01 Thread Xiaoyao Li
On 7/22/2022 12:36 AM, Paolo Bonzini wrote: From: "Jason A. Donenfeld" Tiny machines optimized for fast boot time generally don't use EFI, which means a random seed has to be supplied some other way. For this purpose, Linux (≥5.20) supports passing a seed in the setup_data table with SETUP_RN