Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Jason A. Donenfeld
Hi Alex, On Fri, Jul 22, 2022 at 4:37 PM Alex Bennée wrote: > That sounds suspiciously like inventing a new ABI between QEMU and > guests which we generally try to avoid. Well the ABI is just the "rng-seed" param which is part of the DT spec. But I can understand why you might find this use a bi

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Paolo Bonzini
Ok I will resend the pull request. Apologies for overstepping. Paolo Il ven 22 lug 2022, 16:37 Alex Bennée ha scritto: > > "Jason A. Donenfeld" writes: > > > Hey Alex, > > > > On Fri, Jul 22, 2022 at 10:45:19AM +0100, Alex Bennée wrote: > >> All the guest-loader does is add the information abo

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Alex Bennée
"Jason A. Donenfeld" writes: > Hey Alex, > > On Fri, Jul 22, 2022 at 10:45:19AM +0100, Alex Bennée wrote: >> All the guest-loader does is add the information about where in memory a >> guest and/or it's initrd have been placed in memory to the DTB. It's >> entirely up to the initial booted code

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Jason A. Donenfeld
Hi Paolo, On Fri, Jul 22, 2022 at 02:04:45PM +0200, Paolo Bonzini wrote: > On 7/21/22 22:20, Jason A. Donenfeld wrote: > >> Why are we inserting this here? The guest-loader is only building on > >> what the machine type has already constructed which in the case of -M > >> virt for riscv and ARM al

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Paolo Bonzini
On 7/21/22 22:20, Jason A. Donenfeld wrote: Why are we inserting this here? The guest-loader is only building on what the machine type has already constructed which in the case of -M virt for riscv and ARM already has code for this. Wish you would have replied to the list patch before Paolo que

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Jason A. Donenfeld
Hey Alex, On Fri, Jul 22, 2022 at 10:45:19AM +0100, Alex Bennée wrote: > All the guest-loader does is add the information about where in memory a > guest and/or it's initrd have been placed in memory to the DTB. It's > entirely up to the initial booted code (usually a hypervisor in this > case) to

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-22 Thread Alex Bennée
"Jason A. Donenfeld" writes: > Hi Alex, > > On Thu, Jul 21, 2022 at 08:36:10PM +0100, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >> > uint64_t reg_attr[2] = {cpu_to_be64(s->addr), cpu_to_be64(size)}; >> > +uint8_t rng_seed[32]; >> > >> > if (!fdt) { >> > erro

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-21 Thread Jason A. Donenfeld
Hi Alex, On Thu, Jul 21, 2022 at 08:36:10PM +0100, Alex Bennée wrote: > > Paolo Bonzini writes: > > > From: "Jason A. Donenfeld" > > > > If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to > > initialize early. Set this using the usual guest random number > > generation fun

Re: [PULL 7/9] hw/guest-loader: pass random seed to fdt

2022-07-21 Thread Alex Bennée
Paolo Bonzini writes: > From: "Jason A. Donenfeld" > > If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to > initialize early. Set this using the usual guest random number > generation function. This FDT node is part of the DT specification. > > Cc: Alex Bennée > Signed-of