Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-19 Thread Markus Armbruster
Markus Armbruster writes: > Christian Borntraeger writes: > >> Am 13.10.21 um 11:07 schrieb Paolo Bonzini: >>> From: Markus Armbruster >>> Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" >>> extended find_device_state() to accept QOM paths in addition to qdev >>> IDs. This ad

Re: regression on s390: was Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Markus Armbruster
Christian Borntraeger writes: [...] > The 2nd thing to do is to fix the regression. Does anyone have an idea what > is broken? I do: "device ID or QOM path" arguments where the device ID contains '/'. Undocumented feature, as far as I can tell. I'll fix it anyway. Affects device_del, qemu-io

Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Markus Armbruster
Christian Borntraeger writes: > Am 13.10.21 um 11:07 schrieb Paolo Bonzini: >> From: Markus Armbruster >> Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" >> extended find_device_state() to accept QOM paths in addition to qdev >> IDs. This added a checked conversion to TYPE_DEV

regression on s390: was Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Christian Borntraeger
Am 15.10.21 um 21:15 schrieb Richard Henderson: On 10/15/21 4:08 AM, Christian Borntraeger wrote: Am 13.10.21 um 11:07 schrieb Paolo Bonzini: From: Markus Armbruster Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addit

Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-15 Thread Richard Henderson
On 10/15/21 4:08 AM, Christian Borntraeger wrote: Am 13.10.21 um 11:07 schrieb Paolo Bonzini: From: Markus Armbruster Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addition to qdev IDs.  This added a checked conversion to

Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-15 Thread Christian Borntraeger
Am 13.10.21 um 11:07 schrieb Paolo Bonzini: From: Markus Armbruster Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addition to qdev IDs. This added a checked conversion to TYPE_DEVICE at the end, which duplicates the chec