Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

2023-12-13 Thread Stefan Hajnoczi
On Mon, Dec 11, 2023 at 11:48:05AM +0100, Fiona Ebner wrote: > Am 08.12.23 um 09:32 schrieb Kevin Wolf: > > > > I'm not involved in it myself, but the kind of theme reminds me of this > > downstream bug that Hanna analysed recently: > > > > https://issues.redhat.com/browse/RHEL-3934 > > > > Does

Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

2023-12-11 Thread Fiona Ebner
Am 08.12.23 um 09:32 schrieb Kevin Wolf: > > I'm not involved in it myself, but the kind of theme reminds me of this > downstream bug that Hanna analysed recently: > > https://issues.redhat.com/browse/RHEL-3934 > > Does it look like the same root cause to you? > Thank you for the reference! Ye

Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

2023-12-08 Thread Kevin Wolf
Am 07.12.2023 um 16:22 hat Fiona Ebner geschrieben: > Am 03.11.23 um 14:12 schrieb Fiona Ebner: > > Hi, > > > > I ran into a strange issue where guest IO would get completely stuck > > during certain block jobs a while ago and finally managed to find a > > small reproducer [0]. I'm using a VM with

Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

2023-12-07 Thread Fiona Ebner
Am 03.11.23 um 14:12 schrieb Fiona Ebner: > Hi, > > I ran into a strange issue where guest IO would get completely stuck > during certain block jobs a while ago and finally managed to find a > small reproducer [0]. I'm using a VM with virtio-blk-pci (or > virtio-scsi-pci) with an iothread and runn

Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

2023-11-13 Thread Fiona Ebner
Am 03.11.23 um 14:12 schrieb Fiona Ebner: > Hi, > > Am 30.05.23 um 18:32 schrieb Kevin Wolf: >> From: Stefan Hajnoczi >> >> Detach ioeventfds during drained sections to stop I/O submission from >> the guest. virtio-blk is no longer reliant on aio_disable_external() >> after this patch. This will

Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

2023-11-03 Thread Fiona Ebner
Hi, Am 30.05.23 um 18:32 schrieb Kevin Wolf: > From: Stefan Hajnoczi > > Detach ioeventfds during drained sections to stop I/O submission from > the guest. virtio-blk is no longer reliant on aio_disable_external() > after this patch. This will allow us to remove the > aio_disable_external() API