Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Gerd Hoffmann
Hi, > Sorry for catching this a bit late, but libvirt is looking for "virgl" > property when guest XML has 3D acceleration enabled: Yes, libvirt must be adapted to this. https://gitlab.com/libvirt/libvirt/-/issues/167 As far I know libvirt checks whenever the virgl property exists to figure w

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Gerd Hoffmann
Hi, > (it's not clear to me if virtio-gpu*-device should be user_creatable on x86 > at least) Yes (microvm uses virtio-mmio). take care, Gerd

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Marc-André Lureau
Hi On Fri, May 21, 2021 at 1:34 PM Michal Prívozník wrote: > On 5/10/21 3:20 PM, Gerd Hoffmann wrote: > > Move device init (realize) and properties. > > > > Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no > > matter what. Just use virtio-gpu-device instead if you don't wa

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Michal Prívozník
On 5/10/21 3:20 PM, Gerd Hoffmann wrote: > Move device init (realize) and properties. > > Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no > matter what. Just use virtio-gpu-device instead if you don't want > enable virgl and opengl. This simplifies the logic and reduces th