Re: [PULL 03/15] multifd: Make no compression operations into its own structure

2022-07-19 Thread Markus Armbruster
This fell through the cracks. My apologies. Peter Maydell writes: > On Fri, 28 Feb 2020 at 09:26, Juan Quintela wrote: >> >> It will be used later. >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert >> > > Hi; Coverity thinks there might be a buffer overrun here. > It'

Re: [PULL 03/15] multifd: Make no compression operations into its own structure

2022-07-19 Thread Peter Maydell
Ping^2! I remain unsure how we should resolve this Coverity complaint and would like opinions from QAPI codegen people. thanks -- PMM On Fri, 13 May 2022 at 18:56, Peter Maydell wrote: > > Ping! Any opinions, especially from qapi codegen people, > on the right thing to do here? > > On Tue, 12 Ap

Re: [PULL 03/15] multifd: Make no compression operations into its own structure

2022-05-13 Thread Peter Maydell
Ping! Any opinions, especially from qapi codegen people, on the right thing to do here? On Tue, 12 Apr 2022 at 20:04, Peter Maydell wrote: > > On Fri, 28 Feb 2020 at 09:26, Juan Quintela wrote: > > > > It will be used later. > > > > Signed-off-by: Juan Quintela > > Reviewed-by: Dr. David Alan G

Re: [PULL 03/15] multifd: Make no compression operations into its own structure

2022-04-12 Thread Peter Maydell
On Fri, 28 Feb 2020 at 09:26, Juan Quintela wrote: > > It will be used later. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Hi; Coverity thinks there might be a buffer overrun here. It's probably wrong, but it's not completely obvious why it can't happen, so an assert