Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

2019-10-26 Thread Paolo Bonzini
On 26/10/19 15:20, Philippe Mathieu-Daudé wrote: > On 10/25/19 1:17 PM, Paolo Bonzini wrote: >> On 25/10/19 12:46, Peter Maydell wrote: >>> >>> x86_register_ferr_irq() is defined in target/i386/fpu_helper.c, >>> which is only built if CONFIG_TCG, but the callers don't >>> seem to be similarly guard

Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

2019-10-26 Thread Philippe Mathieu-Daudé
On 10/25/19 1:17 PM, Paolo Bonzini wrote: On 25/10/19 12:46, Peter Maydell wrote: x86_register_ferr_irq() is defined in target/i386/fpu_helper.c, which is only built if CONFIG_TCG, but the callers don't seem to be similarly guarded and there's no stub fallback. Indeed, thanks. I'll add an "i

Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

2019-10-25 Thread Paolo Bonzini
On 25/10/19 12:46, Peter Maydell wrote: > > x86_register_ferr_irq() is defined in target/i386/fpu_helper.c, > which is only built if CONFIG_TCG, but the callers don't > seem to be similarly guarded and there's no stub fallback. Indeed, thanks. I'll add an "if (tcg_enabled())" since this feature

Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

2019-10-25 Thread Peter Maydell
On Thu, 24 Oct 2019 at 15:21, Paolo Bonzini wrote: > > The following changes since commit e9d42461920f6f40f4d847a5ba18e90d095ed0b9: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191018-pull-request' into staging (2019-10-18 > 14:13:11 +0100) > > are available in the git repos

Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

2019-10-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571925835-31930-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24 Type: series Message-id: 1571925835-3193