Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-04-12 Thread Christian Schoenebeck
On Freitag, 8. April 2022 17:00:59 CEST Greg Kurz wrote: > On Fri, 08 Apr 2022 15:52:25 +0200 > > Christian Schoenebeck wrote: > > On Sonntag, 27. Februar 2022 23:35:20 CEST Will Cohen wrote: > > > From: Keno Fischer > > > > > > Darwin does not support mknodat. However, to avoid race conditions

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-04-08 Thread Greg Kurz
On Fri, 08 Apr 2022 15:52:25 +0200 Christian Schoenebeck wrote: > On Sonntag, 27. Februar 2022 23:35:20 CEST Will Cohen wrote: > > From: Keno Fischer > > > > Darwin does not support mknodat. However, to avoid race conditions > > with later setting the permissions, we must avoid using mknod on >

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-04-08 Thread Christian Schoenebeck
On Sonntag, 27. Februar 2022 23:35:20 CEST Will Cohen wrote: > From: Keno Fischer > > Darwin does not support mknodat. However, to avoid race conditions > with later setting the permissions, we must avoid using mknod on > the full path instead. We could try to fchdir, but that would cause > probl

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Christian Schoenebeck
On Montag, 28. Februar 2022 15:06:07 CET Peter Maydell wrote: > On Mon, 28 Feb 2022 at 13:58, Christian Schoenebeck > > wrote: > > On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote: > > > For lines less than 90 characters, it's just a warning, and I think it's > > > ok > > > in such case

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Peter Maydell
On Mon, 28 Feb 2022 at 13:58, Christian Schoenebeck wrote: > > On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote: > > For lines less than 90 characters, it's just a warning, and I think it's ok > > in such cases to keep it longer than 80 characters, if the result of > > breaking it up wou

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Greg Kurz
On Mon, 28 Feb 2022 08:37:10 -0500 Will Cohen wrote: > On Mon, Feb 28, 2022 at 8:20 AM Christian Schoenebeck < > qemu_...@crudebyte.com> wrote: > > > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > > > From: Keno Fischer > > > > > > Darwin does not support mknodat. However, to avo

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Will Cohen
On Mon, Feb 28, 2022 at 8:20 AM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > > From: Keno Fischer > > > > Darwin does not support mknodat. However, to avoid race conditions > > with later setting the permissions, we must av

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Christian Schoenebeck
On Montag, 28. Februar 2022 14:36:30 CET Thomas Huth wrote: > On 28/02/2022 14.20, Christian Schoenebeck wrote: > > On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > >> From: Keno Fischer > >> > >> Darwin does not support mknodat. However, to avoid race conditions > >> with later sett

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Thomas Huth
On 28/02/2022 14.20, Christian Schoenebeck wrote: On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could t

Re: [PATCH v9 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-28 Thread Christian Schoenebeck
On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote: > From: Keno Fischer > > Darwin does not support mknodat. However, to avoid race conditions > with later setting the permissions, we must avoid using mknod on > the full path instead. We could try to fchdir, but that would cause > proble