Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-15 Thread Marc Zyngier
On Wed, 15 Sep 2021 11:58:29 +0100, Alexander Graf wrote: > > > On 15.09.21 11:46, Marc Zyngier wrote: > > On Mon, 13 Sep 2021 13:30:57 +0100, > > Peter Maydell wrote: > >> On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: > >>> > >>> On 13.09.21 13:44, Peter Maydell wrote: > On Mon, 1

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-15 Thread Alexander Graf
On 15.09.21 11:46, Marc Zyngier wrote: > On Mon, 13 Sep 2021 13:30:57 +0100, > Peter Maydell wrote: >> On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: >>> >>> On 13.09.21 13:44, Peter Maydell wrote: On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: > To keep your train of thou

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-15 Thread Marc Zyngier
On Mon, 13 Sep 2021 13:30:57 +0100, Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: > > > > > > On 13.09.21 13:44, Peter Maydell wrote: > > > On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: > > >> To keep your train of thought though, what would you do if we e

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-13 Thread Alexander Graf
On 13.09.21 14:30, Peter Maydell wrote: > On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: >> >> On 13.09.21 13:44, Peter Maydell wrote: >>> On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: To keep your train of thought though, what would you do if we encounter a conduit that

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-13 Thread Peter Maydell
On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: > > > On 13.09.21 13:44, Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: > >> To keep your train of thought though, what would you do if we encounter > >> a conduit that is different from the chosen one? Today, I a

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-13 Thread Alexander Graf
On 13.09.21 13:44, Peter Maydell wrote: > On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: >> >> On 13.09.21 10:54, Peter Maydell wrote: >>> Something in here should be checking whether the insn the guest >>> used matches the PSCI conduit configured for the VM, ie >>> what arm_is_psci_call()

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-13 Thread Peter Maydell
On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: > > > On 13.09.21 10:54, Peter Maydell wrote: > > Something in here should be checking whether the insn the guest > > used matches the PSCI conduit configured for the VM, ie > > what arm_is_psci_call() does after your patch 10. > > > It's yet an

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-13 Thread Alexander Graf
On 13.09.21 10:54, Peter Maydell wrote: > On Mon, 13 Sept 2021 at 00:08, Alexander Graf wrote: >> We need to handle PSCI calls. Most of the TCG code works for us, >> but we can simplify it to only handle aa64 mode and we need to >> handle SUSPEND differently. >> >> This patch takes the TCG code

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

2021-09-13 Thread Peter Maydell
On Mon, 13 Sept 2021 at 00:08, Alexander Graf wrote: > > We need to handle PSCI calls. Most of the TCG code works for us, > but we can simplify it to only handle aa64 mode and we need to > handle SUSPEND differently. > > This patch takes the TCG code as template and duplicates it in HVF. > > To te