Re: [PATCH v8 11/11] target/riscv: rework write_misa()

2023-05-17 Thread Daniel Henrique Barboza
On 5/17/23 01:48, Alistair Francis wrote: On Mon, May 8, 2023 at 8:29 PM Daniel Henrique Barboza wrote: On 5/7/23 20:25, Alistair Francis wrote: On Fri, Apr 21, 2023 at 11:29 PM Daniel Henrique Barboza wrote: write_misa() must use as much common logic as possible. We want to open code

Re: [PATCH v8 11/11] target/riscv: rework write_misa()

2023-05-16 Thread Alistair Francis
On Fri, May 12, 2023 at 10:42 PM Daniel Henrique Barboza wrote: > > Alistair, > > > Since this is the only patch that is being contested is it possible to apply > all > the other ones to riscv-to-apply.next? > > I'm asking because I'm going to send more code that will affect cpu_init() and > risc

Re: [PATCH v8 11/11] target/riscv: rework write_misa()

2023-05-16 Thread Alistair Francis
On Mon, May 8, 2023 at 8:29 PM Daniel Henrique Barboza wrote: > > > > On 5/7/23 20:25, Alistair Francis wrote: > > On Fri, Apr 21, 2023 at 11:29 PM Daniel Henrique Barboza > > wrote: > >> > >> write_misa() must use as much common logic as possible. We want to open > >> code just the bits that are

Re: [PATCH v8 11/11] target/riscv: rework write_misa()

2023-05-12 Thread Daniel Henrique Barboza
Alistair, Since this is the only patch that is being contested is it possible to apply all the other ones to riscv-to-apply.next? I'm asking because I'm going to send more code that will affect cpu_init() and riscv_cpu_realize() functions, and it would be easier if the cleanups were already in

Re: [PATCH v8 11/11] target/riscv: rework write_misa()

2023-05-08 Thread Daniel Henrique Barboza
On 5/7/23 20:25, Alistair Francis wrote: On Fri, Apr 21, 2023 at 11:29 PM Daniel Henrique Barboza wrote: write_misa() must use as much common logic as possible. We want to open code just the bits that are exclusive to the CSR write operation and TCG internals. Our validation is done with r

Re: [PATCH v8 11/11] target/riscv: rework write_misa()

2023-05-07 Thread Alistair Francis
On Fri, Apr 21, 2023 at 11:29 PM Daniel Henrique Barboza wrote: > > write_misa() must use as much common logic as possible. We want to open > code just the bits that are exclusive to the CSR write operation and TCG > internals. > > Our validation is done with riscv_cpu_validate_set_extensions(), b