Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-11 Thread Peter Xu
On Tue, Feb 11, 2025 at 10:22:38PM +0100, William Roche wrote: > On 2/10/25 17:48, Peter Xu wrote: > > On Fri, Feb 07, 2025 at 07:02:22PM +0100, William Roche wrote: > > > [...] > > > So the main reason is a KVM "weakness" with kvm_send_hwpoison_signal(), > > > and > > > the second reason is to ha

Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-11 Thread William Roche
On 2/10/25 17:48, Peter Xu wrote: On Fri, Feb 07, 2025 at 07:02:22PM +0100, William Roche wrote: [...] So the main reason is a KVM "weakness" with kvm_send_hwpoison_signal(), and the second reason is to have richer error messages. This seems true, and I also remember something when I looked at

Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-10 Thread Peter Xu
On Fri, Feb 07, 2025 at 07:02:22PM +0100, William Roche wrote: > On 2/5/25 18:07, Peter Xu wrote: > > On Wed, Feb 05, 2025 at 05:27:13PM +0100, William Roche wrote: > > > [...] > > > The HMP command "info ramblock" is implemented with the ram_block_format() > > > function which returns a message bu

Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-07 Thread William Roche
On 2/5/25 18:07, Peter Xu wrote: On Wed, Feb 05, 2025 at 05:27:13PM +0100, William Roche wrote: [...] The HMP command "info ramblock" is implemented with the ram_block_format() function which returns a message buffer built with a string for each ramblock (protected by the RCU_READ_LOCK_GUARD). O

Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-05 Thread Peter Xu
On Wed, Feb 05, 2025 at 05:27:13PM +0100, William Roche wrote: > On 2/4/25 18:01, Peter Xu wrote: > > On Sat, Feb 01, 2025 at 09:57:23AM +, “William Roche wrote: > > > From: William Roche > > > > > > In case of a large page impacted by a memory error, provide an > > > information about the im

Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-05 Thread William Roche
On 2/4/25 18:01, Peter Xu wrote: On Sat, Feb 01, 2025 at 09:57:23AM +, “William Roche wrote: From: William Roche In case of a large page impacted by a memory error, provide an information about the impacted large page before the memory error injection message. This message would also appe

Re: [PATCH v7 3/6] accel/kvm: Report the loss of a large memory page

2025-02-04 Thread Peter Xu
On Sat, Feb 01, 2025 at 09:57:23AM +, “William Roche wrote: > From: William Roche > > In case of a large page impacted by a memory error, provide an > information about the impacted large page before the memory > error injection message. > > This message would also appear on ras enabled ARM