Re: [PATCH v7 25/42] target/arm: Implement helper_mte_check1

2020-06-19 Thread Richard Henderson
On 6/19/20 6:44 AM, Peter Maydell wrote: >> +/* No-fault version of mte_check1, to be used by SVE for MemSingleNF. */ >> +bool mte_probe1(CPUARMState *env, uint32_t desc, uint64_t ptr, uintptr_t ra) > > If this is a no-fault version, why do we need to pass in the ra ? Excellent question. At firs

Re: [PATCH v7 25/42] target/arm: Implement helper_mte_check1

2020-06-19 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Fill out the stub that was added earlier. > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 47 +++ > target/arm/mte_helper.c | 126 +++- > 2 files changed, 172 inserti

Re: [PATCH v7 25/42] target/arm: Implement helper_mte_check1

2020-06-18 Thread Richard Henderson
On 6/18/20 9:37 AM, Peter Maydell wrote: >> +/* Return true if tbi bits mean that the access is checked. */ >> +static inline bool tbi_check(uint32_t desc, int bit55) >> +{ >> +return (desc >> (R_MTEDESC_TBI_SHIFT + bit55)) & 1; >> +} >> + >> +/* Return true if tcma bits mean that the access i

Re: [PATCH v7 25/42] target/arm: Implement helper_mte_check1

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Fill out the stub that was added earlier. > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h | 47 +++ > target/arm/mte_helper.c | 126 +++- > 2 files changed, 172 inserti