Re: [PATCH v7 1/2] target/s390x: support SHA-512 extensions

2022-08-29 Thread Jason A. Donenfeld
On Fri, Aug 26, 2022 at 12:21:36PM +0200, Thomas Huth wrote: > > + * Copyright (C) 2022 Jason A. Donenfeld . All Rights > > Reserved. > > Please drop the "All rights reserved" ... it does not have any legal meaning No. > > +{ > > +enum { MAX_BLOCKS_PER_RUN = 64 }; /* This is arbitrary, ju

Re: [PATCH v7 1/2] target/s390x: support SHA-512 extensions

2022-08-26 Thread Thomas Huth
Finally, I'm also having some spare minutes to have a look on this ... First, thank you for your work here, it's very appreciated! Some more comments inline below (mostly cosmetics since I'm not very much into this crypto stuff)... On 09/08/2022 17.03, Jason A. Donenfeld wrote: In order to