Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-03 Thread Christian Schoenebeck
On Freitag, 3. Juli 2020 18:08:21 CEST Greg Kurz wrote: > On Fri, 03 Jul 2020 10:08:09 +0200 > > Christian Schoenebeck wrote: > > On Donnerstag, 2. Juli 2020 19:23:35 CEST Christian Schoenebeck wrote: > > > > > Back to the actual topic: so what do we do about the mutex then? > > > > > CoMutex > >

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-03 Thread Christian Schoenebeck
On Freitag, 3. Juli 2020 17:53:15 CEST Greg Kurz wrote: > > > I don't remember questioning the overall concept behind these changes > > > because it looks reasonable enough (even if I would appreciate to be > > > able to verify them with a working reproducer). > > > > What exactly do you mean here

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-03 Thread Greg Kurz
On Fri, 03 Jul 2020 10:08:09 +0200 Christian Schoenebeck wrote: > On Donnerstag, 2. Juli 2020 19:23:35 CEST Christian Schoenebeck wrote: > > > > Back to the actual topic: so what do we do about the mutex then? CoMutex > > > > for 9p2000.u and Mutex for 9p2000.L? I know you find that ugly, but it

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-03 Thread Greg Kurz
On Thu, 02 Jul 2020 19:23:35 +0200 Christian Schoenebeck wrote: > On Donnerstag, 2. Juli 2020 17:35:00 CEST Greg Kurz wrote: > > > > It isn't readdir only, most requests span over multiple v9fs_co_*() > > > > calls...> > > > Right, I know! And that's actually my root motivation to finally bring

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-03 Thread Christian Schoenebeck
On Donnerstag, 2. Juli 2020 19:23:35 CEST Christian Schoenebeck wrote: > > > Back to the actual topic: so what do we do about the mutex then? CoMutex > > > for 9p2000.u and Mutex for 9p2000.L? I know you find that ugly, but it > > > would just be a transitional measure. > > > > That would ruin my

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-02 Thread Christian Schoenebeck
On Donnerstag, 2. Juli 2020 17:35:00 CEST Greg Kurz wrote: > > > It isn't readdir only, most requests span over multiple v9fs_co_*() > > > calls...> > > Right, I know! And that's actually my root motivation to finally bring > > this > > patch set forward, since I am very aware that this patch set

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-02 Thread Greg Kurz
On Thu, 02 Jul 2020 13:43:11 +0200 Christian Schoenebeck wrote: > On Mittwoch, 1. Juli 2020 17:12:40 CEST Greg Kurz wrote: > > On Wed, 01 Jul 2020 13:47:12 +0200 > > > > Christian Schoenebeck wrote: > > > On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > > > > No I'm talking about code

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-02 Thread Christian Schoenebeck
On Mittwoch, 1. Juli 2020 17:12:40 CEST Greg Kurz wrote: > On Wed, 01 Jul 2020 13:47:12 +0200 > > Christian Schoenebeck wrote: > > On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > > > No I'm talking about code that isn't changed by this series: > > > if (initial_offset == 0) { > > >

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-01 Thread Greg Kurz
On Wed, 01 Jul 2020 13:47:12 +0200 Christian Schoenebeck wrote: > On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > > No I'm talking about code that isn't changed by this series: > > > > if (initial_offset == 0) { > > v9fs_co_rewinddir(pdu, fidp); > > } else { > >

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-01 Thread Christian Schoenebeck
On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > No I'm talking about code that isn't changed by this series: > > if (initial_offset == 0) { > v9fs_co_rewinddir(pdu, fidp); > } else { > v9fs_co_seekdir(pdu, fidp, initial_offset); > } > count = v9fs_do_read

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-07-01 Thread Greg Kurz
On Tue, 30 Jun 2020 20:00:08 +0200 Christian Schoenebeck wrote: > On Dienstag, 30. Juni 2020 18:39:57 CEST Greg Kurz wrote: > > On Tue, 30 Jun 2020 17:16:40 +0200 > > > > Christian Schoenebeck wrote: > > > On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > > > > On Wed, 03 Jun 2020 19:16

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-06-30 Thread Christian Schoenebeck
On Dienstag, 30. Juni 2020 18:39:57 CEST Greg Kurz wrote: > On Tue, 30 Jun 2020 17:16:40 +0200 > > Christian Schoenebeck wrote: > > On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > > > On Wed, 03 Jun 2020 19:16:08 +0200 > > > > > > Christian Schoenebeck wrote: > > > > On Sonntag, 19. A

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-06-30 Thread Greg Kurz
On Tue, 30 Jun 2020 17:16:40 +0200 Christian Schoenebeck wrote: > On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > > On Wed, 03 Jun 2020 19:16:08 +0200 > > > > Christian Schoenebeck wrote: > > > On Sonntag, 19. April 2020 17:06:17 CEST Christian Schoenebeck wrote: > > > > Make top half

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-06-30 Thread Christian Schoenebeck
On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > On Wed, 03 Jun 2020 19:16:08 +0200 > > Christian Schoenebeck wrote: > > On Sonntag, 19. April 2020 17:06:17 CEST Christian Schoenebeck wrote: > > > Make top half really top half and bottom half really bottom half: > > > > > > Each T_readd

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-06-29 Thread Greg Kurz
On Wed, 03 Jun 2020 19:16:08 +0200 Christian Schoenebeck wrote: > On Sonntag, 19. April 2020 17:06:17 CEST Christian Schoenebeck wrote: > > Make top half really top half and bottom half really bottom half: > > > > Each T_readdir request handling is hopping between threads (main > > I/O thread an

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

2020-06-03 Thread Christian Schoenebeck
On Sonntag, 19. April 2020 17:06:17 CEST Christian Schoenebeck wrote: > Make top half really top half and bottom half really bottom half: > > Each T_readdir request handling is hopping between threads (main > I/O thread and background I/O driver threads) several times for > every individual direct