Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions

2024-08-21 Thread Deepak Gupta
On Thu, Aug 22, 2024 at 10:57:10AM +1000, Richard Henderson wrote: On 8/22/24 07:50, Deepak Gupta wrote: --- a/target/riscv/insn_trans/trans_rva.c.inc +++ b/target/riscv/insn_trans/trans_rva.c.inc @@ -18,6 +18,8 @@ * this program. If not, see . */ +#include "ex

Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions

2024-08-21 Thread Richard Henderson
On 8/22/24 07:50, Deepak Gupta wrote: --- a/target/riscv/insn_trans/trans_rva.c.inc +++ b/target/riscv/insn_trans/trans_rva.c.inc @@ -18,6 +18,8 @@ * this program. If not, see . */ +#include "exec/memop.h" + Why? This will have been done long ago, withi