Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 04.12.2019 16:03, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Vladimir Sementsov-Ogievskiy writes: >>> 29.11.2019 17:35, Markus Armbruster wrote: >> [...] > I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

04.12.2019 16:03, Markus Armbruster wrote: > Markus Armbruster writes: > >> Vladimir Sementsov-Ogievskiy writes: >> >>> 29.11.2019 17:35, Markus Armbruster wrote: > [...] I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep for your convenience. The commit messages

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Markus Armbruster writes: > Vladimir Sementsov-Ogievskiy writes: > >> 29.11.2019 17:35, Markus Armbruster wrote: [...] >>> I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep >>> for your convenience. The commit messages of the fixed up commits need >>> rephrasing, of cours

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 29.11.2019 17:35, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 28.11.2019 23:29, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 28.11.2019 17:23, Markus Armbruster wrote: >> Vladimir Sementsov-

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 28.11.2019 23:29, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 28.11.2019 17:23, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Error **errp is almost always OUT-argument: it's assumed to be NULL,

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

29.11.2019 17:35, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 28.11.2019 23:29, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> 28.11.2019 17:23, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Error **errp is

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

28.11.2019 23:29, Markus Armbruster wrote: >>> [PATCH v6] block/snapshot: rename Error ** parameter to more common >>> errp >>> [PATCH v6] hw/i386/amd_iommu: rename Error ** parameter to more >>> common errp >>> [PATCH v6] qga: rename Error ** parameter to more common errp >>>

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

28.11.2019 23:29, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 28.11.2019 17:23, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Error **errp is almost always OUT-argument: it's assumed to be NULL, or pointer to NULL-initialized pointer, or

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 28.11.2019 17:23, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Error **errp is almost always OUT-argument: it's assumed to be NULL, or >>> pointer to NULL-initialized pointer, or pointer to error_abort or >>> error_fatal, for cal

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

28.11.2019 17:23, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Error **errp is almost always OUT-argument: it's assumed to be NULL, or >> pointer to NULL-initialized pointer, or pointer to error_abort or >> error_fatal, for callee to report error. >> >> But very few functi

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > Error **errp is almost always OUT-argument: it's assumed to be NULL, or > pointer to NULL-initialized pointer, or pointer to error_abort or > error_fatal, for callee to report error. > > But very few functions instead get Error **errp as IN-argument: > it's