On Wed, Feb 12, 2025 at 11:06:00PM +0530, Prasad Pandit wrote:
> * I was going to send a revised series with these changes, but will
> wait on that for now.
You were going to send some changes that you don't yet fully understand how
it works? How would you do the flush in the new revision if your
Hi,
On Wed, 12 Feb 2025 at 20:08, Peter Xu wrote:
> I think it's not because TLS channels don't send magic, but TLS channels
> are not prone to ordering issues.
> In general, I'm not convinced we need to check names of iochannels.
* If the channel does not set '_READ_MSG_SEEK' flag, which magic
On Wed, Feb 12, 2025 at 06:57:48PM +0530, Prasad Pandit wrote:
> Hi,
>
> On Tue, 11 Feb 2025 at 20:50, Peter Xu wrote:
> > > * Yes. AFAIU, tls/file channels don't send magic values.
> > Please double check whether TLS will send magics. AFAICT, they should.
> ===
> * ... Also tls live migration
Hi,
On Tue, 11 Feb 2025 at 20:50, Peter Xu wrote:
> > * Yes. AFAIU, tls/file channels don't send magic values.
> Please double check whether TLS will send magics. AFAICT, they should.
===
* ... Also tls live migration already does
* tls handshake while initializing main channel so with tls t
On Tue, Feb 11, 2025 at 02:34:07PM +0530, Prasad Pandit wrote:
> On Mon, 10 Feb 2025 at 22:29, Peter Xu wrote:
> > Yes, and I suggest a rename or introduce a new helper, per previous reply.
>
> * Okay, will try it.
>
> > I didn't follow, sorry - do you mean this patch is correct on dropping the
On Mon, 10 Feb 2025 at 22:29, Peter Xu wrote:
> Yes, and I suggest a rename or introduce a new helper, per previous reply.
* Okay, will try it.
> I didn't follow, sorry - do you mean this patch is correct on dropping the
> mapped-ram check? I don't yet understand how it can work if without.
* I
On Sat, Feb 08, 2025 at 04:06:56PM +0530, Prasad Pandit wrote:
> Hello Peter,
>
> On Fri, 7 Feb 2025 at 21:16, Peter Xu wrote:
> > This is not easy to follow neither with the current name, nor that you
> > "assumed this is main channel" and test it.
>
> * It is not my doing, nor is there any ass
Hello Peter,
On Fri, 7 Feb 2025 at 21:16, Peter Xu wrote:
> This is not easy to follow neither with the current name, nor that you
> "assumed this is main channel" and test it.
* It is not my doing, nor is there any assumption, but that is how
current implementation works.
===
static bool migrat
On Fri, Feb 07, 2025 at 04:02:44PM +0530, Prasad Pandit wrote:
> Hi,
>
> On Fri, 7 Feb 2025 at 04:46, Peter Xu wrote:
> > > +/* Migration channel types */
> > > +enum { CH_DEFAULT, CH_MULTIFD, CH_POSTCOPY };
> >
> > Maybe s/DEFAULT/MAIN/?
>
> * Okay.
>
> > > -if (migrate_multifd() && !migra
Hi,
On Fri, 7 Feb 2025 at 04:46, Peter Xu wrote:
> > +/* Migration channel types */
> > +enum { CH_DEFAULT, CH_MULTIFD, CH_POSTCOPY };
>
> Maybe s/DEFAULT/MAIN/?
* Okay.
> > -if (migrate_multifd() && !migrate_mapped_ram() &&
> > -!migrate_postcopy_ram() &&
> > -qio_channel_h
On Wed, Feb 05, 2025 at 05:57:10PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit
>
> Enable Multifd and Postcopy migration together.
> The migration_ioc_process_incoming() routine
> checks magic value sent on each channel and
> helps to properly setup multifd and postcopy
> channels.
>
> The
11 matches
Mail list logo
