Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-22 Thread Peter Maydell
On Fri, 4 Sep 2020 at 10:03, Markus Armbruster wrote: > Peter Maydell writes: > > Make the handling of indentation in doc comments more sophisticated, > > so that when we see a section like: > > > > Notes: some text > >some more text > > indented line 3 > > > > we save it for th

Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-22 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 22 Sep 2020 at 08:27, Markus Armbruster wrote: >> How does >> >> @foo: bar >> baz >> @frob: gnu >> gnat >> >> behave? > > The rST fragments would be: > > bar > baz > > gnu > gnat > > So you get what rST does with that. We do actually have

Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-22 Thread Peter Maydell
On Tue, 22 Sep 2020 at 08:27, Markus Armbruster wrote: > How does > > @foo: bar > baz > @frob: gnu > gnat > > behave? The rST fragments would be: bar baz gnu gnat So you get what rST does with that. We do actually have examples of this in the existing QAPI doc comments

Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-22 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 4 Sep 2020 at 10:03, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > Make the handling of indentation in doc comments more sophisticated, > >> > def append(self, line): >> > +# Strip leading spaces corresponding to the expected i

Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-21 Thread Peter Maydell
On Fri, 4 Sep 2020 at 10:03, Markus Armbruster wrote: > > Peter Maydell writes: > > > Make the handling of indentation in doc comments more sophisticated, > > def append(self, line): > > +# Strip leading spaces corresponding to the expected indent > > level > > +

Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-09-04 Thread Markus Armbruster
Peter Maydell writes: > Make the handling of indentation in doc comments more sophisticated, > so that when we see a section like: > > Notes: some text >some more text > indented line 3 > > we save it for the doc-comment processing code as: > > some text > some more text >in