Re: [PATCH v5 06/17] hw/misc: Add nr_regs and cold_reset_values to NPCM GCR

2025-02-25 Thread Peter Maydell
On Wed, 19 Feb 2025 at 18:46, Hao Wu wrote: > > These 2 values are different between NPCM7XX and NPCM8XX > GCRs. So we add them to the class and assign different values > to them. > > Reviewed-by: Peter Maydell > Signed-off-by: Hao Wu > @@ -156,10 +157,12 @@ static const struct MemoryRegionOps

Re: [PATCH v5 06/17] hw/misc: Add nr_regs and cold_reset_values to NPCM GCR

2025-02-24 Thread Hao Wu
Thanks! I can review the patch. On Mon, Feb 24, 2025 at 12:52 PM Pierrick Bouvier < pierrick.bouv...@linaro.org> wrote: > Hello, > > This patch introduces a buffer-overflow, now reported by address sanitizer. > > I sent a patch: > https://lore.kernel.org/qemu-devel/20250224205053.104959-1- > pier

Re: [PATCH v5 06/17] hw/misc: Add nr_regs and cold_reset_values to NPCM GCR

2025-02-24 Thread Pierrick Bouvier
Hello, This patch introduces a buffer-overflow, now reported by address sanitizer. I sent a patch: https://lore.kernel.org/qemu-devel/20250224205053.104959-1- pierrick.bouv...@linaro.org/T/#u You're welcome to review it, or fix the problem differently if there is a better approach. Regards,