Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-04 Thread John Snow
On Thu, Feb 3, 2022 at 4:19 AM Kevin Wolf wrote: > > Am 02.02.2022 um 20:08 hat John Snow geschrieben: > > > I guess the relevant question in the context of this patch is whether > > > sync.py will need a similar two-phase setup as legacy.py. Do you think > > > you can do without it when you have

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-03 Thread John Snow
On Thu, Feb 3, 2022 at 4:38 AM Daniel P. Berrangé wrote: > > On Wed, Feb 02, 2022 at 02:08:59PM -0500, John Snow wrote: > > On Tue, Feb 1, 2022 at 2:46 PM Kevin Wolf wrote: > > > > > > Am 01.02.2022 um 19:32 hat John Snow geschrieben: > > > > On Tue, Feb 1, 2022 at 8:21 AM Kevin Wolf wrote: > >

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-03 Thread Daniel P . Berrangé
On Wed, Feb 02, 2022 at 02:08:59PM -0500, John Snow wrote: > On Tue, Feb 1, 2022 at 2:46 PM Kevin Wolf wrote: > > > > Am 01.02.2022 um 19:32 hat John Snow geschrieben: > > > On Tue, Feb 1, 2022 at 8:21 AM Kevin Wolf wrote: > > > > > > > > Am 01.02.2022 um 05:11 hat John Snow geschrieben: > > > >

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-03 Thread Kevin Wolf
Am 02.02.2022 um 20:08 hat John Snow geschrieben: > > I guess the relevant question in the context of this patch is whether > > sync.py will need a similar two-phase setup as legacy.py. Do you think > > you can do without it when you have to reintroduce this behaviour here > > to fix bugs? > > > >

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-02 Thread John Snow
On Tue, Feb 1, 2022 at 2:46 PM Kevin Wolf wrote: > > Am 01.02.2022 um 19:32 hat John Snow geschrieben: > > On Tue, Feb 1, 2022 at 8:21 AM Kevin Wolf wrote: > > > > > > Am 01.02.2022 um 05:11 hat John Snow geschrieben: > > > > The synchronous QMP library would bind to the server address during > >

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-01 Thread Kevin Wolf
Am 01.02.2022 um 19:32 hat John Snow geschrieben: > On Tue, Feb 1, 2022 at 8:21 AM Kevin Wolf wrote: > > > > Am 01.02.2022 um 05:11 hat John Snow geschrieben: > > > The synchronous QMP library would bind to the server address during > > > __init__(). The new library delays this to the accept() cal

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-01 Thread John Snow
On Tue, Feb 1, 2022 at 8:21 AM Kevin Wolf wrote: > > Am 01.02.2022 um 05:11 hat John Snow geschrieben: > > The synchronous QMP library would bind to the server address during > > __init__(). The new library delays this to the accept() call, because > > binding occurs inside of the call to start_[u

Re: [PATCH v4 4/4] python/aqmp: add socket bind step to legacy.py

2022-02-01 Thread Kevin Wolf
Am 01.02.2022 um 05:11 hat John Snow geschrieben: > The synchronous QMP library would bind to the server address during > __init__(). The new library delays this to the accept() call, because > binding occurs inside of the call to start_[unix_]server(), which is an > async method -- so it cannot ha