Re: [PATCH v4 33/33] hw/nios2: Machine with a Vectored Interrupt Controller

2022-03-08 Thread Richard Henderson
On 3/7/22 22:43, Mark Cave-Ayland wrote: +    qdev_realize(DEVICE(cpu), NULL, &error_fatal); +    object_unref(CPU(cpu)); I believe this can be replaced with qdev_realize_and_unref()? Oh, nice. I copied this from hw/arm/virt, which has code between these two points. +    if (nms->vic) { +

Re: [PATCH v4 33/33] hw/nios2: Machine with a Vectored Interrupt Controller

2022-03-08 Thread Mark Cave-Ayland
On 08/03/2022 07:20, Richard Henderson wrote: From: Amir Gonnen Demonstrate how to use nios2 VIC on a machine. Introduce a new machine property to attach a VIC. When VIC is present, let the CPU know that it should use the External Interrupt Interface instead of the Internal Interrupt Interfac