Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-11 Thread wangyanan (Y)
On 2021/11/11 17:37, Philippe Mathieu-Daudé wrote: On 11/11/21 10:31, wangyanan (Y) wrote: On 2021/11/11 17:14, Philippe Mathieu-Daudé wrote: On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: From: Yanan Wang Now that we have a generic parser smp_parse(), let's add an unit test for the code

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-11 Thread Philippe Mathieu-Daudé
On 11/11/21 10:31, wangyanan (Y) wrote: > > On 2021/11/11 17:14, Philippe Mathieu-Daudé wrote: >> On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: >>> From: Yanan Wang >>> >>> Now that we have a generic parser smp_parse(), let's add an unit >>> test for the code. All possible valid/invalid SMP co

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-11 Thread wangyanan (Y)
On 2021/11/11 17:14, Philippe Mathieu-Daudé wrote: On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: From: Yanan Wang Now that we have a generic parser smp_parse(), let's add an unit test for the code. All possible valid/invalid SMP configurations that the user can specify are covered. Signe

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-11 Thread Philippe Mathieu-Daudé
On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: > From: Yanan Wang > > Now that we have a generic parser smp_parse(), let's add an unit > test for the code. All possible valid/invalid SMP configurations > that the user can specify are covered. > > Signed-off-by: Yanan Wang > Reviewed-by: Andre

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-10 Thread Thomas Huth
On 09/11/2021 13.18, wangyanan (Y) wrote: Hi, On 2021/11/9 17:36, Philippe Mathieu-Daudé wrote: Hi, On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: From: Yanan Wang Now that we have a generic parser smp_parse(), let's add an unit test for the code. All possible valid/invalid SMP configurat

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-09 Thread wangyanan (Y)
Hi, On 2021/11/9 17:36, Philippe Mathieu-Daudé wrote: Hi, On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: From: Yanan Wang Now that we have a generic parser smp_parse(), let's add an unit test for the code. All possible valid/invalid SMP configurations that the user can specify are covered.

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-09 Thread wangyanan (Y)
On 2021/11/9 17:36, Philippe Mathieu-Daudé wrote: Hi, On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: From: Yanan Wang Now that we have a generic parser smp_parse(), let's add an unit test for the code. All possible valid/invalid SMP configurations that the user can specify are covered.

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-09 Thread Philippe Mathieu-Daudé
Hi, On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: > From: Yanan Wang > > Now that we have a generic parser smp_parse(), let's add an unit > test for the code. All possible valid/invalid SMP configurations > that the user can specify are covered. > > Signed-off-by: Yanan Wang > Reviewed-by:

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-11-01 Thread Philippe Mathieu-Daudé
On 10/31/21 13:02, wangyanan (Y) wrote: > Hi Philippe, > > I saw that there are some cross-build failures and a clang complain > about this patch in your triggered CI pipeline. I believe the minor > diff below will resolve them. If you are going to resend v2 of the > "qdev-hotplug" patches, I woul

Re: [PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-10-31 Thread wangyanan (Y)
Hi Philippe, I saw that there are some cross-build failures and a clang complain about this patch in your triggered CI pipeline. I believe the minor diff below will resolve them. If you are going to resend v2 of the "qdev-hotplug" patches, I would very much appreciate it if you can also help to r