Re: [PATCH v4 05/15] qemu-iotests: delay QMP socket timers

2021-06-03 Thread Emanuele Giuseppe Esposito
On 03/06/2021 14:25, Vladimir Sementsov-Ogievskiy wrote: 03.06.2021 14:03, Emanuele Giuseppe Esposito wrote: So, you just make the class do nothing.. I'd prefer something like this: @contextmanager def NoTimeout:     yield if qemu_gdb:    Timeout = NoTimeout I am not sure I understand

Re: [PATCH v4 05/15] qemu-iotests: delay QMP socket timers

2021-06-03 Thread Vladimir Sementsov-Ogievskiy
03.06.2021 14:03, Emanuele Giuseppe Esposito wrote: So, you just make the class do nothing.. I'd prefer something like this: @contextmanager def NoTimeout:     yield if qemu_gdb:    Timeout = NoTimeout I am not sure I understand what you want to do here. I have a basic understanding of @co

Re: [PATCH v4 05/15] qemu-iotests: delay QMP socket timers

2021-06-03 Thread Emanuele Giuseppe Esposito
So, you just make the class do nothing.. I'd prefer something like this: @contextmanager def NoTimeout:    yield if qemu_gdb:   Timeout = NoTimeout I am not sure I understand what you want to do here. I have a basic understanding of @contextmanager, but can you explain more what you wan

Re: [PATCH v4 05/15] qemu-iotests: delay QMP socket timers

2021-05-28 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito --- tests/qemu-iotests/iotests.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)