Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule

2020-06-05 Thread Philippe Mathieu-Daudé
On 6/1/20 9:26 AM, Philippe Mathieu-Daudé wrote: > On 6/1/20 4:13 AM, Richard Henderson wrote: >> On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote: >>> + $(if $(call startwith,risc,$1),risc,\ >> >> Should be "riscv" not "risc". Especially the substitution. > > Indeed. > >> >>> +

Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule

2020-06-01 Thread Philippe Mathieu-Daudé
On 6/1/20 4:13 AM, Richard Henderson wrote: > On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote: >> + $(if $(call startwith,risc,$1),risc,\ > > Should be "riscv" not "risc". Especially the substitution. Indeed. > >> +$(if $(call startwith,aarch64,$1),arm,\ >

Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule

2020-05-31 Thread Richard Henderson
On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote: > + $(if $(call startwith,risc,$1),risc,\ Should be "riscv" not "risc". Especially the substitution. > + $(if $(call startwith,aarch64,$1),arm,\ > + $(if $(call startwith,x86_64,$1),i386