Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-28 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if -gdb is not provided but $GDB_OPTION

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-27 Thread Vladimir Sementsov-Ogievskiy
27.05.2021 14:06, Emanuele Giuseppe Esposito wrote: On 26/05/2021 21:15, Vladimir Sementsov-Ogievskiy wrote: 20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only a

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-27 Thread Emanuele Giuseppe Esposito
On 26/05/2021 21:15, Vladimir Sementsov-Ogievskiy wrote: 20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the im

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if -gdb is not provided but $GDB_OPTION

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Emanuele Giuseppe Esposito
On 26/05/2021 15:25, Vladimir Sementsov-Ogievskiy wrote: 26.05.2021 15:48, Paolo Bonzini wrote: On 26/05/21 13:24, Vladimir Sementsov-Ogievskiy wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options Why make a mix of two styles? --

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 15:48, Paolo Bonzini wrote: On 26/05/21 13:24, Vladimir Sementsov-Ogievskiy wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options Why make a mix of two styles? -- suggests that single-character options like -d and -v can b

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Paolo Bonzini
On 26/05/21 13:24, Vladimir Sementsov-Ogievskiy wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options Why make a mix of two styles? -- suggests that single-character options like -d and -v can be combined, is that the case? if -gdb

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable Let's use --option notation for new long options to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementa