Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

2021-12-17 Thread Stefan Hajnoczi
On Fri, Dec 17, 2021 at 02:31:14AM +, Jag Raman wrote: > > > > On Dec 16, 2021, at 4:58 AM, Stefan Hajnoczi wrote: > > > > On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: > >> +static void vfu_object_set_socket(Object *obj, Visitor *v, const char > >> *name, > >> +

Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

2021-12-16 Thread Jag Raman
> On Dec 16, 2021, at 4:58 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: >> +static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name, >> + void *opaque, Error **errp) >> +{ >> +VfuObject

Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

2021-12-16 Thread Jag Raman
> On Dec 16, 2021, at 4:33 AM, Stefan Hajnoczi wrote: > > On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: >> diff --git a/qapi/qom.json b/qapi/qom.json >> index ccd1167808..6001a9b8f0 100644 >> --- a/qapi/qom.json >> +++ b/qapi/qom.json >> @@ -703,6 +703,20 @@ >> { 'struct':

Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

2021-12-16 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: > +static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name, > + void *opaque, Error **errp) > +{ > +VfuObject *o = VFU_OBJECT(obj); > + > +qapi_free_SocketAddress(o->socke

Re: [PATCH v4 04/14] vfio-user: define vfio-user-server object

2021-12-16 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:35:28AM -0500, Jagannathan Raman wrote: > diff --git a/qapi/qom.json b/qapi/qom.json > index ccd1167808..6001a9b8f0 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -703,6 +703,20 @@ > { 'struct': 'RemoteObjectProperties', >'data': { 'fd': 'str', 'devid': 'str