Re: [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code

2020-09-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 9/21/20 9:53 PM, Richard Henderson wrote: >> On 9/21/20 12:29 PM, Alex Bennée wrote: >>> >>> Richard Henderson writes: >>> Instead of creating GStrings and passing them into log_disas, just print the annotations directly in tb_gen_code. F

Re: [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code

2020-09-22 Thread Philippe Mathieu-Daudé
On 9/21/20 9:53 PM, Richard Henderson wrote: > On 9/21/20 12:29 PM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> Instead of creating GStrings and passing them into log_disas, >>> just print the annotations directly in tb_gen_code. >>> >>> Fix the annotations for the slow paths of the

Re: [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code

2020-09-21 Thread Richard Henderson
On 9/21/20 12:29 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> Instead of creating GStrings and passing them into log_disas, >> just print the annotations directly in tb_gen_code. >> >> Fix the annotations for the slow paths of the TB, after the >> part implementing the final guest i

Re: [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code

2020-09-21 Thread Alex Bennée
Richard Henderson writes: > Instead of creating GStrings and passing them into log_disas, > just print the annotations directly in tb_gen_code. > > Fix the annotations for the slow paths of the TB, after the > part implementing the final guest instruction. > > Reviewed-by: Thomas Huth > Signed