Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-10-16 Thread Markus Armbruster
Peter Xu writes: > On Mon, Oct 16, 2023 at 08:29:58AM +0200, Markus Armbruster wrote: >> Better, because even stupider: drop the feature flags. They have no >> effect on internal use, and there is no external use. >> >> ## >> # @MigrationParameter: >> # >> # TODO: elide from gen

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-10-16 Thread Peter Xu
On Mon, Oct 16, 2023 at 08:29:58AM +0200, Markus Armbruster wrote: > Better, because even stupider: drop the feature flags. They have no > effect on internal use, and there is no external use. > > ## > # @MigrationParameter: > # > # TODO: elide from generated documentation (type i

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-10-16 Thread Markus Armbruster
Peter Xu writes: > On Tue, Sep 26, 2023 at 10:43:22PM +0200, Markus Armbruster wrote: >> Loophole... Here's the stupidest solution that could possibly work: >> >> ## >> # @MigrationParameter: >> # >> # TODO: elide from generated documentation (type is used only >> # inte

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-10-02 Thread Peter Xu
On Tue, Sep 26, 2023 at 10:43:22PM +0200, Markus Armbruster wrote: > Loophole... Here's the stupidest solution that could possibly work: > > ## > # @MigrationParameter: > # > # TODO: elide from generated documentation (type is used only > # internally, and not visible in Q

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-26 Thread Markus Armbruster
Peter Xu writes: > Drop the enum in qapi because it is never used in QMP APIs. Instead making > it an internal definition for QEMU so that we can decouple it from QAPI, > and also we can deduplicate the QAPI documentations. > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Peter Xu The enu

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-26 Thread Peter Xu
On Wed, Sep 06, 2023 at 11:46:16AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 06, 2023 at 12:14:54PM +0200, Philippe Mathieu-Daudé wrote: > > On 6/9/23 11:00, Daniel P. Berrangé wrote: > > > On Wed, Sep 06, 2023 at 06:42:16AM +0200, Philippe Mathieu-Daudé wrote: > > > > On 5/9/23 18:23, Peter X

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-06 Thread Daniel P . Berrangé
On Wed, Sep 06, 2023 at 12:14:54PM +0200, Philippe Mathieu-Daudé wrote: > On 6/9/23 11:00, Daniel P. Berrangé wrote: > > On Wed, Sep 06, 2023 at 06:42:16AM +0200, Philippe Mathieu-Daudé wrote: > > > On 5/9/23 18:23, Peter Xu wrote: > > > > Drop the enum in qapi because it is never used in QMP APIs.

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-06 Thread Philippe Mathieu-Daudé
On 6/9/23 11:00, Daniel P. Berrangé wrote: On Wed, Sep 06, 2023 at 06:42:16AM +0200, Philippe Mathieu-Daudé wrote: On 5/9/23 18:23, Peter Xu wrote: Drop the enum in qapi because it is never used in QMP APIs. Instead making it an internal definition for QEMU so that we can decouple it from QAPI

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-06 Thread Daniel P . Berrangé
On Wed, Sep 06, 2023 at 06:42:16AM +0200, Philippe Mathieu-Daudé wrote: > On 5/9/23 18:23, Peter Xu wrote: > > Drop the enum in qapi because it is never used in QMP APIs. Instead making > > it an internal definition for QEMU so that we can decouple it from QAPI, > > and also we can deduplicate the

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 18:23, Peter Xu wrote: Drop the enum in qapi because it is never used in QMP APIs. Instead making it an internal definition for QEMU so that we can decouple it from QAPI, and also we can deduplicate the QAPI documentations. Reviewed-by: Daniel P. Berrangé Signed-off-by: Peter Xu ---