Re: [PATCH v3 38/43] hw/loongarch: Add LoongArch ls7a rtc device support

2022-05-10 Thread Richard Henderson
On 5/10/22 02:11, yangxiaojuan wrote: Why does only register 0 affect expire time, and not all 3 registers? Thanks, the toymatch[1]/[2] should also affect expire time. I fixed it like this: +static void rtc_toymatch_write(LS7ARtcState *s, struct tm *tm, uint64_t val) +{ +    int64_t alarm_off

Re: [PATCH v3 38/43] hw/loongarch: Add LoongArch ls7a rtc device support

2022-05-10 Thread yangxiaojuan
On 2022/5/8 上午5:55, Richard Henderson wrote: On 4/29/22 05:07, Xiaojuan Yang wrote: +/* + * Shift bits and filed mask + */ +#define TOY_MON_MASK   0x3f +#define TOY_DAY_MASK   0x1f +#define TOY_HOUR_MASK  0x1f +#define TOY_MIN_MASK   0x3f +#define TOY_SEC_MASK   0x3f +#define TOY_MSEC_MASK  0x

Re: [PATCH v3 38/43] hw/loongarch: Add LoongArch ls7a rtc device support

2022-05-07 Thread Richard Henderson
On 4/29/22 05:07, Xiaojuan Yang wrote: +/* + * Shift bits and filed mask + */ +#define TOY_MON_MASK 0x3f +#define TOY_DAY_MASK 0x1f +#define TOY_HOUR_MASK 0x1f +#define TOY_MIN_MASK 0x3f +#define TOY_SEC_MASK 0x3f +#define TOY_MSEC_MASK 0xf + +#define TOY_MON_SHIFT 26 +#define TOY_DAY_