Re: [PATCH v3 2/9] dump: Remove the sh_info variable

2022-03-31 Thread Marc-André Lureau
Hi On Thu, Mar 31, 2022 at 1:47 PM Janosch Frank wrote: > On 3/31/22 10:58, Marc-André Lureau wrote: > > Hi > > > > On Wed, Mar 30, 2022 at 4:48 PM Janosch Frank > wrote: > > > >> There's no need to have phdr_num and sh_info at the same time. We can > >> make phdr_num 32 bit and set PN_XNUM whe

Re: [PATCH v3 2/9] dump: Remove the sh_info variable

2022-03-31 Thread Janosch Frank
On 3/31/22 10:58, Marc-André Lureau wrote: Hi On Wed, Mar 30, 2022 at 4:48 PM Janosch Frank wrote: There's no need to have phdr_num and sh_info at the same time. We can make phdr_num 32 bit and set PN_XNUM when we write the header if phdr_num >= PN_XNUM. I am not fond of this change tbh, m

Re: [PATCH v3 2/9] dump: Remove the sh_info variable

2022-03-31 Thread Marc-André Lureau
Hi On Wed, Mar 30, 2022 at 4:48 PM Janosch Frank wrote: > There's no need to have phdr_num and sh_info at the same time. We can > make phdr_num 32 bit and set PN_XNUM when we write the header if > phdr_num >= PN_XNUM. > I am not fond of this change tbh, mixing variables, casting a u32 to u16..