Re: [PATCH v3 08/49] semihosting: Inline set_swi_errno into common_semi_cb

2022-05-23 Thread Peter Maydell
On Mon, 23 May 2022 at 15:58, Richard Henderson wrote: > > On 5/23/22 03:58, Peter Maydell wrote: > > On Sat, 21 May 2022 at 01:04, Richard Henderson > > wrote: > >> > >> Do not store 'err' into errno only to read it back immediately. > >> Use 'ret' for the return value, not 'reg0'. > >> > >> Sig

Re: [PATCH v3 08/49] semihosting: Inline set_swi_errno into common_semi_cb

2022-05-23 Thread Richard Henderson
On 5/23/22 03:58, Peter Maydell wrote: On Sat, 21 May 2022 at 01:04, Richard Henderson wrote: Do not store 'err' into errno only to read it back immediately. Use 'ret' for the return value, not 'reg0'. Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 19 ++--

Re: [PATCH v3 08/49] semihosting: Inline set_swi_errno into common_semi_cb

2022-05-23 Thread Peter Maydell
On Sat, 21 May 2022 at 01:04, Richard Henderson wrote: > > Do not store 'err' into errno only to read it back immediately. > Use 'ret' for the return value, not 'reg0'. > > Signed-off-by: Richard Henderson > --- > semihosting/arm-compat-semi.c | 19 ++- > 1 file changed, 10 inser