Re: [PATCH v3] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-10-18 Thread Richard Henderson
On 10/18/20 11:34 AM, Philippe Mathieu-Daudé wrote: >> +    g_assert(size != 0); > > "The alignment value, which must be an integer power of 2.", > so maybe: > >    g_assert(size != 0 && is_power_of_2(alignment)); This is also true of posix_memalign. If we are going to add this, we should a

Re: [PATCH v3] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-10-18 Thread Philippe Mathieu-Daudé
On 10/18/20 6:48 PM, Richard Henderson wrote: We do not need or want to be allocating page sized quanta. Signed-off-by: Richard Henderson --- v3: Include ; use g_assert not assert. --- util/oslib-win32.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/util/osl

Re: [PATCH v3] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-10-18 Thread Stefan Weil
Am 18.10.20 um 18:48 schrieb Richard Henderson: We do not need or want to be allocating page sized quanta. Signed-off-by: Richard Henderson --- v3: Include ; use g_assert not assert. --- util/oslib-win32.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/util/