Re: [PATCH v2 5/8] target/arm: Take an exception if PC is misaligned

2021-09-20 Thread Richard Henderson
On 9/20/21 1:08 AM, Peter Maydell wrote: On Mon, 20 Sept 2021 at 02:29, Richard Henderson wrote: On 8/26/21 6:45 AM, Peter Maydell wrote: I don't think you should need to special case AArch64 vs AArch32 like this; you can do env->exception.vaddress = pc; env->exception.fsr = the_fsr

Re: [PATCH v2 5/8] target/arm: Take an exception if PC is misaligned

2021-09-20 Thread Peter Maydell
On Mon, 20 Sept 2021 at 02:29, Richard Henderson wrote: > > On 8/26/21 6:45 AM, Peter Maydell wrote: > > I don't think you should need to special case AArch64 vs AArch32 like this; > > you can do > > env->exception.vaddress = pc; > > env->exception.fsr = the_fsr; > > raise_exception(en

Re: [PATCH v2 5/8] target/arm: Take an exception if PC is misaligned

2021-09-19 Thread Richard Henderson
On 8/26/21 6:45 AM, Peter Maydell wrote: On Sat, 21 Aug 2021 at 21:00, Richard Henderson wrote: For A64, any input to an indirect branch can cause this. For A32, many indirect branch paths force the branch to be aligned, but BXWritePC does not. This includes the BX instruction but also other

Re: [PATCH v2 5/8] target/arm: Take an exception if PC is misaligned

2021-08-26 Thread Peter Maydell
On Sat, 21 Aug 2021 at 21:00, Richard Henderson wrote: > > For A64, any input to an indirect branch can cause this. > > For A32, many indirect branch paths force the branch to be aligned, > but BXWritePC does not. This includes the BX instruction but also > other interworking changes to PC. Prio