Re: [PATCH v2 3/6] qemu-option: restrict qemu_opts_set to merge-lists QemuOpts

2020-11-09 Thread Paolo Bonzini
On 09/11/20 19:52, Markus Armbruster wrote: Do you think working (some of) this into commit message would be worth your while? Easy and does not require a respin, so yes. Improve the testcase, though I should have mentioned it in the commit message. Basically emulating "-kernel bc -kernel de

Re: [PATCH v2 3/6] qemu-option: restrict qemu_opts_set to merge-lists QemuOpts

2020-11-09 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/11/20 16:55, Markus Armbruster wrote: >>> QemuOptsList *net = qemu_find_opts("net"); >>> -qemu_opts_set(net, NULL, "type", "nic", &error_abort); >>> +qemu_opts_parse(net, "nic", true, &error_abort); >>> #ifdef CONFIG_SLIRP >>> -qem

Re: [PATCH v2 3/6] qemu-option: restrict qemu_opts_set to merge-lists QemuOpts

2020-11-09 Thread Paolo Bonzini
On 09/11/20 16:55, Markus Armbruster wrote: QemuOptsList *net = qemu_find_opts("net"); -qemu_opts_set(net, NULL, "type", "nic", &error_abort); +qemu_opts_parse(net, "nic", true, &error_abort); #ifdef CONFIG_SLIRP -qemu_opts_set(net, NULL, "type", "user", &error

Re: [PATCH v2 3/6] qemu-option: restrict qemu_opts_set to merge-lists QemuOpts

2020-11-09 Thread Markus Armbruster
Paolo Bonzini writes: > qemu_opts_set is used to create default network backends and to > parse sugar options -kernel, -initrd, -append, -bios and -dtb. > Switch the former to qemu_opts_parse, so that qemu_opts_set > is now only used on merge-lists QemuOptsList (for which it makes > the most sens