Re: [PATCH v2 3/4] Introduce the NVMM impl

2020-02-05 Thread Maxime Villard
Hi Le 03/02/2020 à 12:51, Philippe Mathieu-Daudé a écrit : +static void +nvmm_io_callback(struct nvmm_io *io) +{ +    MemTxAttrs attrs = { 0 }; +    int ret; + +    ret = address_space_rw(&address_space_io, io->port, attrs, io->data, +    io->size, !io->in); +    if (ret != MEMTX_OK) { +

Re: [PATCH v2 3/4] Introduce the NVMM impl

2020-02-05 Thread Kamil Rytarowski
On 03.02.2020 12:51, Philippe Mathieu-Daudé wrote: > Except the XXX comments, LGTM but I'm not a X86 guy. > > These comments were old and I will drop them and resubmit.

Re: [PATCH v2 3/4] Introduce the NVMM impl

2020-02-03 Thread Philippe Mathieu-Daudé
On 1/28/20 3:09 PM, Kamil Rytarowski wrote: From: Maxime Villard Implements the NetBSD Virtual Machine Monitor (NVMM) target. Which acts as a hypervisor accelerator for QEMU on the NetBSD platform. This enables QEMU much greater speed over the emulated x86_64 path's that are taken on NetBSD tod