Re: [PATCH v2 27/76] target/microblaze: Check singlestep_enabled in gen_goto_tb

2020-08-31 Thread Richard Henderson
On 8/31/20 6:54 AM, Edgar E. Iglesias wrote: >> +TCGv_i32 tmp = tcg_const_i32(EXCP_DEBUG); >> +tcg_gen_movi_i64(cpu_SR[SR_PC], dest); > > This needs to be i32 cpu_pc to avoid breaking bisection. Looks like this > part slipped over to the next patch. > > With that fixed: > Reviewed

Re: [PATCH v2 27/76] target/microblaze: Check singlestep_enabled in gen_goto_tb

2020-08-31 Thread Edgar E. Iglesias
On Fri, Aug 28, 2020 at 07:18:40AM -0700, Richard Henderson wrote: > Do not use goto_tb if we're single-stepping. > > Signed-off-by: Richard Henderson > --- > target/microblaze/translate.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/target/microblaze/translate