Re: [PATCH v2 23/53] migration/rdma: Fix QEMUFileHooks method return values

2023-10-04 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> The QEMUFileHooks methods don't come with a written contract. Digging >> through the code calling them, we find: >> >> * save_page(): >> >> Negative values RAM_SAVE_CONTROL_DELAYED and >> RAM_SAVE_CONTROL_NOT_SUPP are special. Any other n

Re: [PATCH v2 23/53] migration/rdma: Fix QEMUFileHooks method return values

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > The QEMUFileHooks methods don't come with a written contract. Digging > through the code calling them, we find: > > * save_page(): > > Negative values RAM_SAVE_CONTROL_DELAYED and > RAM_SAVE_CONTROL_NOT_SUPP are special. Any other negative value is > an unspecifi

Re: [PATCH v2 23/53] migration/rdma: Fix QEMUFileHooks method return values

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > The QEMUFileHooks methods don't come with a written contract. Digging > through the code calling them, we find: > > * save_page(): > > Negative values RAM_SAVE_CONTROL_DELAYED and > RAM_SAVE_CONTROL_NOT_SUPP are special. Any other negative value is > an unspecifi