Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 16:57, Alex Bennée wrote: > > > Beata Michalska writes: > > > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > > wrote: > >> qemu_log_mask w/ GUEST_ERROR? How do we expect the length to overflow? > > > > In theory it shouldn't, at least with current usage. > > I guess the

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Alex Bennée
Beata Michalska writes: > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > wrote: >> >> On 11/6/19 12:40 AM, Beata Michalska wrote: >> > +void qemu_ram_writeback(RAMBlock *block, ram_addr_t start, ram_addr_t >> > length) >> > +{ >> > +void *addr = ramblock_ptr(block, start); >> > + >> > +

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Beata Michalska
On Wed, 6 Nov 2019 at 12:20, Richard Henderson wrote: > > On 11/6/19 12:40 AM, Beata Michalska wrote: > > +void qemu_ram_writeback(RAMBlock *block, ram_addr_t start, ram_addr_t > > length) > > +{ > > +void *addr = ramblock_ptr(block, start); > > + > > +/* > > + * The requested range m

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-06 Thread Richard Henderson
On 11/6/19 12:40 AM, Beata Michalska wrote: > +void qemu_ram_writeback(RAMBlock *block, ram_addr_t start, ram_addr_t length) > +{ > +void *addr = ramblock_ptr(block, start); > + > +/* > + * The requested range might spread up to the very end of the block > + */ > +if ((start + l