Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-17 Thread Mark Cave-Ayland
On 16/10/2020 01:26, BALATON Zoltan via wrote: As said in previous message the i2c and SPD patches are not quite ready yet so I've omitted those from this series, I may rework them later once this part is merged and can rebase the rest on top of that. We would also need your screamer patches to

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-16 Thread David Gibson
On Fri, Oct 16, 2020 at 07:53:10AM +0100, Mark Cave-Ayland wrote: > On 16/10/2020 07:45, Howard Spoelstra wrote: > > > Hi, > > > > I see compilation of the current ppc-for-5.2 branch fail with: > > > > ../hw/pci-host/grackle.c: In function ‘grackle_realize’: > > ../hw/pci-host/grackle.c:68:11: e

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread Mark Cave-Ayland
On 16/10/2020 07:45, Howard Spoelstra wrote: Hi, I see compilation of the current ppc-for-5.2 branch fail with: ../hw/pci-host/grackle.c: In function ‘grackle_realize’: ../hw/pci-host/grackle.c:68:11: error: ‘GrackleState’ has no member named ‘pic’    68 |     if (!s->pic) {       |        

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread Howard Spoelstra
On Fri, Oct 16, 2020 at 2:30 AM David Gibson wrote: > On Tue, Oct 13, 2020 at 12:49:21PM +0100, Mark Cave-Ayland wrote: > > Currently an object link property is used to pass a reference to the > Heathrow > > PIC into the PCI host bridge so that grackle_init_irqs() can connect the > PCI > > IRQs t

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 12:49:21PM +0100, Mark Cave-Ayland wrote: > Currently an object link property is used to pass a reference to the Heathrow > PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI > IRQs to the PIC itself. > > This can be simplified by defining the PCI

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread BALATON Zoltan via
On Thu, 15 Oct 2020, Mark Cave-Ayland wrote: I've queued the grackle/uninorth patches to my qemu-macppc branch, however when I try to apply patches from the above series git fails with the following message: Applying: mac_oldworld: Drop a variable, use get_system_memory() directly error: sha1

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-15 Thread Mark Cave-Ayland
On 13/10/2020 18:05, BALATON Zoltan via wrote: Hello, Not related to this patch but while you're at it could you please take those patches that are already reviewed by you from this series as well? http://patchwork.ozlabs.org/project/qemu-devel/list/?series=186439 That would help cleaning u

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-13 Thread BALATON Zoltan via
Hello, Not related to this patch but while you're at it could you please take those patches that are already reviewed by you from this series as well? http://patchwork.ozlabs.org/project/qemu-devel/list/?series=186439 That would help cleaning up my tree and see which patches still need chang

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-13 Thread Mark Cave-Ayland
On 13/10/2020 14:37, Philippe Mathieu-Daudé wrote: On 10/13/20 1:49 PM, Mark Cave-Ayland wrote: Currently an object link property is used to pass a reference to the Heathrow PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplif

Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 1:49 PM, Mark Cave-Ayland wrote: Currently an object link property is used to pass a reference to the Heathrow PIC into the PCI host bridge so that grackle_init_irqs() can connect the PCI IRQs to the PIC itself. This can be simplified by defining the PCI IRQs as qdev gpios and then w