Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-05 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 5 Apr 2023 at 15:56, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > I think on balance I would go for: > > > * remove (ie deprecate-and-drop) 'singlestep' from the QMP struct, > > >ra

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-05 Thread Peter Maydell
On Wed, 5 Apr 2023 at 15:56, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > I think on balance I would go for: > > * remove (ie deprecate-and-drop) 'singlestep' from the QMP struct, > >rather than merely renaming it > > * if anybody comes along and sa

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-05 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 4 Apr 2023 at 14:25, Markus Armbruster wrote: > > > > Peter Maydell writes: > > > > > On Tue, 4 Apr 2023 at 09:25, Markus Armbruster wrote: > > >> Hmm. We report it in query-status, which means it's relevant to QMP > > >> clients. We

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-04 Thread Paolo Bonzini
On 4/4/23 16:24, Peter Maydell wrote: I think on balance I would go for: * remove (ie deprecate-and-drop) 'singlestep' from the QMP struct, rather than merely renaming it * if anybody comes along and says they want to do this via QMP, implement Paolo's idea of putting the accelerator

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-04 Thread Peter Maydell
On Tue, 4 Apr 2023 at 14:25, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Tue, 4 Apr 2023 at 09:25, Markus Armbruster wrote: > >> Hmm. We report it in query-status, which means it's relevant to QMP > >> clients. We provide the command to control it only in HMP, which means > >>

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-04 Thread Paolo Bonzini
On 4/4/23 11:17, Peter Maydell wrote: I don't want to add a QMP interface for writing it unless there's somebody who actually has a use case for it. We could place the accelerator at a well-known QOM path such as /machine/accel, and then qom-set can already be used to implement such an inter

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-04 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 4 Apr 2023 at 09:25, Markus Armbruster wrote: >> >> In the title: "qmp:" >> >> Peter Maydell writes: >> > diff --git a/qapi/run-state.json b/qapi/run-state.json >> > index 9d34afa39e0..1de8c5c55d0 100644 >> > --- a/qapi/run-state.json >> > +++ b/qapi/run-state.js

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-04 Thread Peter Maydell
On Tue, 4 Apr 2023 at 09:25, Markus Armbruster wrote: > > In the title: "qmp:" > > Peter Maydell writes: > > diff --git a/qapi/run-state.json b/qapi/run-state.json > > index 9d34afa39e0..1de8c5c55d0 100644 > > --- a/qapi/run-state.json > > +++ b/qapi/run-state.json > > @@ -104,16 +104,27 @@ > >

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-04 Thread Markus Armbruster
In the title: "qmp:" Peter Maydell writes: > The 'singlestep' member of StatusInfo has never done what > the QMP documentation claims it does. What it actually > reports is whether TCG is working in "one guest instruction > per translation block" mode. > > Create a new 'one-insn-per-tb' member