Re: [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Eric Blake
On 1/20/21 10:15 AM, Gerd Hoffmann wrote: > On Wed, Jan 20, 2021 at 04:35:20PM +0100, Philippe Mathieu-Daudé wrote: >> While these requests are invalid, they are not breaking any laws :) >> Rename 'illegal request' as 'invalid request'. > > Given the scsi spec calls this "illegal request" I think

Re: [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Gerd Hoffmann
On Wed, Jan 20, 2021 at 04:35:20PM +0100, Philippe Mathieu-Daudé wrote: > While these requests are invalid, they are not breaking any laws :) > Rename 'illegal request' as 'invalid request'. Given the scsi spec calls this "illegal request" I think it makes sense to *not* change this and stay cons

Re: [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Eric Blake
On 1/20/21 9:35 AM, Philippe Mathieu-Daudé wrote: > While these requests are invalid, they are not breaking any laws :) > Rename 'illegal request' as 'invalid request'. > > Suggested-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé > --- > include/scsi/utils.h | 20 ++-- >