Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-11-13 Thread Eric Blake
On 10/15/19 11:16 AM, Vladimir Sementsov-Ogievskiy wrote: @@ -1561,6 +1569,8 @@ NBDExport *nbd_export_new(BlockDriverState *bs, uint64_t dev_offset,    exp->export_bitmap = bm;    exp->export_bitmap_context = g_strdup_printf("qemu:dirty-bitmap:%s",    

Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-11-04 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:16 +, Vladimir Sementsov-Ogievskiy wrote: > 15.10.2019 18:07, Eric Blake wrote: > > On 10/11/19 2:32 AM, Vladimir Sementsov-Ogievskiy wrote: > > > 11.10.2019 0:00, Eric Blake wrote: > > > > Qemu as server currently won't accept export names larger than 256 > > > > bytes

Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-10-15 Thread Vladimir Sementsov-Ogievskiy
15.10.2019 18:07, Eric Blake wrote: > On 10/11/19 2:32 AM, Vladimir Sementsov-Ogievskiy wrote: >> 11.10.2019 0:00, Eric Blake wrote: >>> Qemu as server currently won't accept export names larger than 256 >>> bytes, nor create dirty bitmap names longer than 1023 bytes, so most >>> uses of qemu as cl

Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-10-15 Thread Eric Blake
On 10/11/19 2:32 AM, Vladimir Sementsov-Ogievskiy wrote: 11.10.2019 0:00, Eric Blake wrote: Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near

Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
11.10.2019 0:00, Eric Blake wrote: > Qemu as server currently won't accept export names larger than 256 > bytes, nor create dirty bitmap names longer than 1023 bytes, so most > uses of qemu as client or server have no reason to get anywhere near > the NBD spec maximum of a 4k limit per string. > >