Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-28 Thread Kshitij Suri
Hi, Hope this mail finds you well. I have updated the code as required and would be grateful if you could review and suggest changes that are needed to be implemented. In case no change is required, please do let me know the next steps for the same. Regards, Kshitij Suri On 22/03/22 4:19 pm,

Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-22 Thread Kshitij Suri
On 22/03/22 3:12 pm, Daniel P. Berrangé wrote: On Tue, Mar 22, 2022 at 08:18:44AM +, Kshitij Suri wrote: Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed

Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-22 Thread Daniel P . Berrangé
On Tue, Mar 22, 2022 at 08:18:44AM +, Kshitij Suri wrote: > Libpng is only detected if VNC is enabled currently. This patch adds a > generalised png option in the meson build which is aimed to replace use of > CONFIG_VNC_PNG with CONFIG_PNG. > > Signed-off-by: Kshitij Suri > --- > meson.buil

Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-15 Thread Paolo Bonzini
On 3/15/22 05:47, Kshitij Suri wrote: +png = dependency('libpng', required: get_option('png'), + method: 'pkg-config', kwargs: static_kwargs) The full way to write it would be: png = not_found if get_option('png').allowed() and have_system png = dependency('libpng', required:

Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-03-07 Thread Kshitij Suri
Hi, Hope this mail finds you well. I have updated the code as required and request you to review and suggest changes that are needed to be implemented. In case no change is required, please do let me know the next steps for the same. Regards, Kshitij Suri On 01/03/22 12:14 pm, Kshitij Suri

Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-02-28 Thread Philippe Mathieu-Daudé
On 28/2/22 06:22, Kshitij Suri wrote: Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed-off-by: Kshitij Suri --- meson.build| 10 +- meson_op