Re: [PATCH v2 09/12] target/arm: Optimize MVE VSHL, VSHR immediate forms

2021-09-16 Thread Richard Henderson
On 9/16/21 3:01 AM, Peter Maydell wrote: On Mon, 13 Sept 2021 at 16:53, Richard Henderson wrote: On 9/13/21 7:21 AM, Peter Maydell wrote: On Mon, 13 Sept 2021 at 14:56, Richard Henderson wrote: On 9/13/21 2:54 AM, Peter Maydell wrote: +static void do_gvec_shri_s(unsigned vece, uint32_t do

Re: [PATCH v2 09/12] target/arm: Optimize MVE VSHL, VSHR immediate forms

2021-09-16 Thread Peter Maydell
On Mon, 13 Sept 2021 at 16:53, Richard Henderson wrote: > > On 9/13/21 7:21 AM, Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 14:56, Richard Henderson > > wrote: > >> > >> On 9/13/21 2:54 AM, Peter Maydell wrote: > >>> +static void do_gvec_shri_s(unsigned vece, uint32_t dofs, uint32_t aofs, >

Re: [PATCH v2 09/12] target/arm: Optimize MVE VSHL, VSHR immediate forms

2021-09-13 Thread Richard Henderson
On 9/13/21 7:21 AM, Peter Maydell wrote: On Mon, 13 Sept 2021 at 14:56, Richard Henderson wrote: On 9/13/21 2:54 AM, Peter Maydell wrote: +static void do_gvec_shri_s(unsigned vece, uint32_t dofs, uint32_t aofs, + int64_t shift, uint32_t oprsz, uint32_t maxsz) +{ +

Re: [PATCH v2 09/12] target/arm: Optimize MVE VSHL, VSHR immediate forms

2021-09-13 Thread Peter Maydell
On Mon, 13 Sept 2021 at 14:56, Richard Henderson wrote: > > On 9/13/21 2:54 AM, Peter Maydell wrote: > > +static void do_gvec_shri_s(unsigned vece, uint32_t dofs, uint32_t aofs, > > + int64_t shift, uint32_t oprsz, uint32_t maxsz) > > +{ > > +/* > > + * We get her

Re: [PATCH v2 09/12] target/arm: Optimize MVE VSHL, VSHR immediate forms

2021-09-13 Thread Richard Henderson
On 9/13/21 2:54 AM, Peter Maydell wrote: +static void do_gvec_shri_s(unsigned vece, uint32_t dofs, uint32_t aofs, + int64_t shift, uint32_t oprsz, uint32_t maxsz) +{ +/* + * We get here with a negated shift count, and we must handle + * shifts by the element