Re: [PATCH v2 05/38] qapi: Remove wildcard includes

2020-09-24 Thread John Snow
On 9/23/20 1:21 PM, John Snow wrote: On 9/23/20 9:27 AM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote: Wildcard includes become hard to manage when refactoring and dealing with circular dependencies with strictly typed mypy. flake8 also flags each one as a warni

Re: [PATCH v2 05/38] qapi: Remove wildcard includes

2020-09-24 Thread Cleber Rosa
On Wed, Sep 23, 2020 at 01:21:37PM -0400, John Snow wrote: > On 9/23/20 9:27 AM, Cleber Rosa wrote: > > On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote: > > > Wildcard includes become hard to manage when refactoring and dealing > > > with circular dependencies with strictly typed mypy. >

Re: [PATCH v2 05/38] qapi: Remove wildcard includes

2020-09-23 Thread John Snow
On 9/23/20 9:27 AM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote: Wildcard includes become hard to manage when refactoring and dealing with circular dependencies with strictly typed mypy. flake8 also flags each one as a warning, as it is not smart enough to know

Re: [PATCH v2 05/38] qapi: Remove wildcard includes

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote: > Wildcard includes become hard to manage when refactoring and dealing > with circular dependencies with strictly typed mypy. > > flake8 also flags each one as a warning, as it is not smart enough to > know which names exist in the importe

Re: [PATCH v2 05/38] qapi: Remove wildcard includes

2020-09-22 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote: > Wildcard includes become hard to manage when refactoring and dealing > with circular dependencies with strictly typed mypy. > > flake8 also flags each one as a warning, as it is not smart enough to > know which names exist in the importe