Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB

2021-07-08 Thread Peter Maydell
On Thu, 8 Jul 2021 at 17:17, Richard Henderson wrote: > > On 7/8/21 9:11 AM, Peter Maydell wrote: > >>> Why isn't it enough here just to set is_jmp to DISAS_NEXT ? > >> > >> You mean DISAS_TOO_MANY? That would work, yes. > >> At the time I was just thinking of replacing one jump with another. > >

Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB

2021-07-08 Thread Richard Henderson
On 7/8/21 9:11 AM, Peter Maydell wrote: Why isn't it enough here just to set is_jmp to DISAS_NEXT ? You mean DISAS_TOO_MANY? That would work, yes. At the time I was just thinking of replacing one jump with another. You've implicitly answered my question, which is that the main translator loo

Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB

2021-07-08 Thread Peter Maydell
On Thu, 8 Jul 2021 at 17:04, Richard Henderson wrote: > > On 7/8/21 5:05 AM, Peter Maydell wrote: > > On Wed, 30 Jun 2021 at 19:47, Richard Henderson > > wrote: > >> > >> Using gen_goto_tb directly misses the single-step check. > >> > >> Cc: qemu-...@nongnu.org > >> Signed-off-by: Richard Henders

Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB

2021-07-08 Thread Richard Henderson
On 7/8/21 5:05 AM, Peter Maydell wrote: On Wed, 30 Jun 2021 at 19:47, Richard Henderson wrote: Using gen_goto_tb directly misses the single-step check. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB

2021-07-08 Thread Peter Maydell
On Wed, 30 Jun 2021 at 19:47, Richard Henderson wrote: > > Using gen_goto_tb directly misses the single-step check. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ar