John Snow writes:
> On 12/16/20 2:51 AM, Markus Armbruster wrote:
>> Is it too late to delay the introduction of type hints until after
>> the
>> data structure cleanups?
>> If yes, I have to spend more time replying below.
>>
>
> No, I re-ordered the series again to delay typing until the end,
Eduardo Habkost writes:
> On Wed, Dec 16, 2020 at 08:51:10AM +0100, Markus Armbruster wrote:
> [...]
>> You guys clearly struggled with the tree data structure. Documentation
>> would have helped[*]. Since you're going to replace it (PATCH 09),
>> adding it now makes little sense.
>>
>> *My* s
On 12/16/20 2:51 AM, Markus Armbruster wrote:
Is it too late to delay the introduction of type hints until after the
data structure cleanups?
If yes, I have to spend more time replying below.
No, I re-ordered the series again to delay typing until the end, or
close to it.
Though I abandon
On Wed, Dec 16, 2020 at 08:51:10AM +0100, Markus Armbruster wrote:
[...]
> You guys clearly struggled with the tree data structure. Documentation
> would have helped[*]. Since you're going to replace it (PATCH 09),
> adding it now makes little sense.
>
> *My* struggle is with the type annotation
John Snow writes:
> On 11/13/20 11:48 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> The typing of _make_tree and friends is a bit involved, but it can be
>>> done with some stubbed out types and a bit of elbow grease. The
>>> forthcoming patches attempt to make some simplifications,
On 11/13/20 11:48 AM, Markus Armbruster wrote:
John Snow writes:
The typing of _make_tree and friends is a bit involved, but it can be
done with some stubbed out types and a bit of elbow grease. The
forthcoming patches attempt to make some simplifications, but having the
type hints in advance
On 11/6/20 9:12 PM, Cleber Rosa wrote:
On Mon, Oct 26, 2020 at 03:42:45PM -0400, John Snow wrote:
The typing of _make_tree and friends is a bit involved, but it can be
done with some stubbed out types and a bit of elbow grease. The
forthcoming patches attempt to make some simplifications, but ha
John Snow writes:
> The typing of _make_tree and friends is a bit involved, but it can be
> done with some stubbed out types and a bit of elbow grease. The
> forthcoming patches attempt to make some simplifications, but having the
> type hints in advance may aid in review of subsequent patches.
>
On Mon, Oct 26, 2020 at 03:42:45PM -0400, John Snow wrote:
> The typing of _make_tree and friends is a bit involved, but it can be
> done with some stubbed out types and a bit of elbow grease. The
> forthcoming patches attempt to make some simplifications, but having the
> type hints in advance may
