Re: [PATCH v2 04/10] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain

2021-07-17 Thread Alex Bennée
Richard Henderson writes: > On 7/17/21 10:39 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> The purpose of suppressing goto_ptr from -d nochain had been >>> to return to the main loop so that -d cpu would be recognized. >> Hmm is it though? I've always treated it as ensuring we al

Re: [PATCH v2 04/10] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain

2021-07-17 Thread Richard Henderson
On 7/17/21 10:39 AM, Alex Bennée wrote: Richard Henderson writes: The purpose of suppressing goto_ptr from -d nochain had been to return to the main loop so that -d cpu would be recognized. Hmm is it though? I've always treated it as ensuring we always come out into the main loop (which is

Re: [PATCH v2 04/10] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain

2021-07-17 Thread Alex Bennée
Richard Henderson writes: > The purpose of suppressing goto_ptr from -d nochain had been > to return to the main loop so that -d cpu would be recognized. Hmm is it though? I've always treated it as ensuring we always come out into the main loop (which is helpful for debugging). > But we now i

Re: [PATCH v2 04/10] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain

2021-07-17 Thread Peter Maydell
On Mon, 12 Jul 2021 at 16:44, Richard Henderson wrote: > > The purpose of suppressing goto_ptr from -d nochain had been > to return to the main loop so that -d cpu would be recognized. > But we now include -d cpu logging in helper_lookup_tb_ptr so > there is no need to exclude goto_ptr. > > Signed