Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Yonggang Luo
On Wed, Sep 16, 2020 at 1:14 AM Paolo Bonzini wrote: > > On 15/09/20 19:07, 罗勇刚(Yonggang Luo) wrote: > > > > Linux distributions generally do not want to have bundled libraries, so > > > > Yes, bundled libraries is a bad idea, but static linked library is > > another case, that won't affect >

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Yonggang Luo
On Wed, Sep 16, 2020 at 1:00 AM Paolo Bonzini wrote: > On 15/09/20 18:12, 罗勇刚(Yonggang Luo) wrote: > > > > I suggest remove the capstone=system option cause the system library > > may not satisfy the requirements of qemu and create in-consistence > > expereince when bug or error happens about cap

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Paolo Bonzini
On 15/09/20 19:07, 罗勇刚(Yonggang Luo) wrote: > > Linux distributions generally do not want to have bundled libraries, so > > Yes, bundled libraries is a bad idea, but static linked library is > another case, that won't affect > the Linux distributions.  As far as Linux distributions are conce

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Paolo Bonzini
On 15/09/20 18:12, 罗勇刚(Yonggang Luo) wrote: > > I suggest remove the capstone=system option cause the system library > may not satisfy the requirements of qemu and create in-consistence > expereince when bug or error happens about capstone. We either have > git submodule capstone or nothing at all

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Paolo Bonzini
On 15/09/20 16:27, Richard Henderson wrote: > On 9/14/20 11:27 PM, Paolo Bonzini wrote: >> Looks good. Can you just add a "# Submodules" heading above the test? >> >> I would also like to remove the "yes" value (that is, the default fails if >> the >> internal copy is not there) but it can be done

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Yonggang Luo
On Tue, Sep 15, 2020 at 10:27 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/14/20 11:27 PM, Paolo Bonzini wrote: > > Looks good. Can you just add a "# Submodules" heading above the test? > > > > I would also like to remove the "yes" value (that is, the default fails > if the >

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-15 Thread Richard Henderson
On 9/14/20 11:27 PM, Paolo Bonzini wrote: > Looks good. Can you just add a "# Submodules" heading above the test? > > I would also like to remove the "yes" value (that is, the default fails if the > internal copy is not there) but it can be done later for all submodules. Unless you simply plan to

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Paolo Bonzini
Looks good. Can you just add a "# Submodules" heading above the test? I would also like to remove the "yes" value (that is, the default fails if the internal copy is not there) but it can be done later for all submodules. Paolo Il mar 15 set 2020, 01:06 Richard Henderson ha scritto: > On 9/14/

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Thomas Huth
On 15/09/2020 01.02, Richard Henderson wrote: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always r

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Richard Henderson
On 9/14/20 4:02 PM, Richard Henderson wrote: > +option('capstone', type: 'combo', value: 'no', > + choices: ['no', 'yes', 'auto', 'system', 'internal'], > + description: 'Whether and how to find the capstone library') Dangit, meant to change value: back to 'auto'. r~